-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compare_map_segmentation): change to using kinematic_state topic #4448
fix(compare_map_segmentation): change to using kinematic_state topic #4448
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
015a3a2
to
7876644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4448 +/- ##
=======================================
Coverage 14.91% 14.91%
=======================================
Files 1516 1516
Lines 104652 104645 -7
Branches 31853 31853
=======================================
Hits 15610 15610
+ Misses 72007 72000 -7
Partials 17035 17035
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…utowarefoundation#4448) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…utowarefoundation#4448) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Description
Related links
TIER IV INTERNAL LINK
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.