Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compare_map_segmentation): change to using kinematic_state topic #4448

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jul 28, 2023

Description

  • Change the topic to obtain ego-vehicle position in dynamic map loader mode of compare map segmentation.

Related links

TIER IV INTERNAL LINK

Tests performed

  • Confirm map comparing result using Logging_simulor.
    image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 28, 2023
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen requested a review from yukke42 July 28, 2023 15:14
@badai-nguyen badai-nguyen marked this pull request as ready for review July 28, 2023 15:18
@badai-nguyen badai-nguyen force-pushed the fix/compare_map_unuse_initialize_state branch from 015a3a2 to 7876644 Compare July 28, 2023 15:34
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 29, 2023
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e47d83) 14.91% compared to head (7876644) 14.91%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4448   +/-   ##
=======================================
  Coverage   14.91%   14.91%           
=======================================
  Files        1516     1516           
  Lines      104652   104645    -7     
  Branches    31853    31853           
=======================================
  Hits        15610    15610           
+ Misses      72007    72000    -7     
  Partials    17035    17035           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 5e47d83

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...compare_map_segmentation/voxel_grid_map_loader.hpp 0.00% <ø> (ø)
...are_map_segmentation/src/voxel_grid_map_loader.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen merged commit 8a13959 into autowarefoundation:main Jul 30, 2023
badai-nguyen added a commit to badai-nguyen/autoware.universe that referenced this pull request Jul 30, 2023
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants