Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): extract occlusion contour as polygon #4442

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jul 28, 2023

Description

This feature replaces the occlusion grid with occlusion polygon and filtering based on its size.

Related links

Tier IV COMPANY INTERNAL LINK
launcher PR: autowarefoundation/autoware_launch#485

Tests performed

Psim

use_occlusion_polygon_scenario-2023-07-28_16.37.36.mp4

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 28, 2023
@soblin soblin changed the title Feat/intersection/extract occlusion contour feat(intersection): extract occlusion contour as polygon Jul 28, 2023
@soblin soblin force-pushed the feat/intersection/extract-occlusion-contour branch from 442f2ae to 73f3a4e Compare July 28, 2023 08:08
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (b8aad73) 14.91% compared to head (80f5f7d) 14.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4442      +/-   ##
==========================================
- Coverage   14.91%   14.91%   -0.01%     
==========================================
  Files        1517     1517              
  Lines      104685   104698      +13     
  Branches    31869    31875       +6     
==========================================
  Hits        15613    15613              
- Misses      72035    72047      +12     
- Partials    17037    17038       +1     
Flag Coverage Δ *Carryforward flag
differential 7.36% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from b8aad73

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_intersection_module/src/manager.cpp 19.32% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin force-pushed the feat/intersection/extract-occlusion-contour branch from 9fcff45 to df5f3fc Compare July 28, 2023 09:56
@soblin soblin added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 28, 2023
@soblin soblin force-pushed the feat/intersection/extract-occlusion-contour branch from df5f3fc to d53b385 Compare July 29, 2023 02:25
@soblin soblin requested a review from KYabuuchi as a code owner July 29, 2023 02:25
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 29, 2023
soblin and others added 10 commits July 29, 2023 11:27
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This reverts commit 42562acd925786cafe0d86e3400af5e68cce712c.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/extract-occlusion-contour branch from d53b385 to 80f5f7d Compare July 29, 2023 02:27
@github-actions github-actions bot removed component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 29, 2023
@soblin soblin merged commit 83ead41 into autowarefoundation:main Jul 29, 2023
@soblin soblin deleted the feat/intersection/extract-occlusion-contour branch July 29, 2023 08:04
soblin added a commit to tier4/autoware.universe that referenced this pull request Jul 31, 2023
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 1, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 8, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants