Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tier4_localization_launch): change input/pointcloud param #4411

Merged
merged 3 commits into from
Jul 28, 2023
Merged

refactor(tier4_localization_launch): change input/pointcloud param #4411

merged 3 commits into from
Jul 28, 2023

Conversation

yvzksgl
Copy link
Member

@yvzksgl yvzksgl commented Jul 26, 2023

Description

This PR is about keep autoware.universe keep integrated with autoware_launch. The changes become necessary after autowarefoundation/autoware_launch#480

Tests performed

İt worked without error on logging simulator.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jul 26, 2023
@yvzksgl yvzksgl mentioned this pull request Jul 26, 2023
Merged
4 tasks
@yvzksgl yvzksgl self-assigned this Jul 26, 2023
KYabuuchi
KYabuuchi reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This change looks good.
I made one minor suggestion, please take a look at it.

launch/tier4_localization_launch/launch/pose_twist_estimator/pose_twist_estimator.launch.xml Outdated Show resolved Hide resolved
@KYabuuchi KYabuuchi added component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 27, 2023
@github-actions github-actions bot removed the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (e181dce) 14.93% compared to head (9c6786c) 14.93%.
Report is 6 commits behind head on main.

❗ Current head 9c6786c differs from pull request most recent head 4167375. Consider uploading reports for the commit 4167375 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4411      +/-   ##
==========================================
- Coverage   14.93%   14.93%   -0.01%     
==========================================
  Files        1515     1515              
  Lines      104547   104545       -2     
  Branches    31779    31777       -2     
==========================================
- Hits        15616    15613       -3     
+ Misses      71896    71895       -1     
- Partials    17035    17037       +2
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 14.93% <ø> (-0.01%) ⬇️ Carriedforward from 13b96ad

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KYabuuchi
KYabuuchi approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@KYabuuchi
Copy link
Contributor

@yvzksgl Please add the -s flag when committing to Autoware from the next time so that DCO can be passed. (i.e., git commit -s)
For details, please refer to the documentation page or check the CI checks.

image

@KYabuuchi
Copy link
Contributor

Can I merge this PR myself?
If you have write access to Autoware, you can pass the DCO using the button below and merge it yourself.

@yvzksgl yvzksgl merged commit dd8e1d6 into main Jul 28, 2023
@yvzksgl yvzksgl deleted the refactor/localization-launch-params branch July 28, 2023 09:08
@yvzksgl
Copy link
Member Author

yvzksgl commented Jul 28, 2023

I merged with autowarefoundation/autoware_launch#480. Thank you.

@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 31, 2023
Merged
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 1, 2023
@yvzksgl @kminoda
refactor(tier4_localization_launch): change input/pointcloud param (a…
1c9035b 
…utowarefoundation#4411)

* refactor(tier4_localization_launch): change input/pointcloud param

* parameter renaming moved util.launch.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KYabuuchi KYabuuchi KYabuuchi approved these changes

@kminoda kminoda Awaiting requested review from kminoda

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

Assignees

@yvzksgl yvzksgl

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvzksgl @KYabuuchi