Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tier4_perception_launch): fix typo #4406

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 26, 2023

Description

fix typo of tier4_perception_launch

Tests performed

spell check

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 26, 2023
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jul 26, 2023
@HansRobo HansRobo changed the title fix(tier4_perception_launch): fix typo chore(tier4_perception_launch): fix typo Jul 27, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review July 27, 2023 14:30
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@miursh @YoshiRi Could you approve the PR.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (13b96ad) 14.93% compared to head (936c815) 14.93%.
Report is 25 commits behind head on main.

❗ Current head 936c815 differs from pull request most recent head 7c13267. Consider uploading reports for the commit 7c13267 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4406   +/-   ##
=======================================
  Coverage   14.93%   14.93%           
=======================================
  Files        1515     1515           
  Lines      104545   104545           
  Branches    31777    31777           
=======================================
  Hits        15613    15613           
  Misses      71895    71895           
  Partials    17037    17037           
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 14.93% <ø> (ø) Carriedforward from 13b96ad

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukkysaito
Copy link
Contributor

#4429
It overlaps with this one.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25
Copy link
Contributor

knzo25 commented Jul 27, 2023

@takayuki5168
Sorry, did not see this PR
🙇
Will close mine

@takayuki5168
Copy link
Contributor Author

@knzo25 Sorry about that. Then I will merge mine.

@takayuki5168 takayuki5168 merged commit 7fb9b8a into autowarefoundation:main Jul 27, 2023
@takayuki5168 takayuki5168 deleted the fix/tier4-perception-launch-typo branch July 27, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants