fix(traffic_light): fix traffic_light_arbiter pipeline #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
1222-takeshi
requested review from
knzo25,
miursh,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
component:perception
7 tasks
|
cc. @0x126 @TomohitoAndo |
miursh
reviewed
Jul 27, 2023
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
miursh
approved these changes
Jul 27, 2023
knzo25
approved these changes
Jul 27, 2023
1222-takeshi
added
the
run:build-and-test-differential
7 tasks
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 28, 2023
…ation#4393) * fix(traffic_light): fix traffic_light_arbiter pipeline Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> * style(pre-commit): autofix * fix: output topic name Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> --------- Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, arguments were not passed from traffic_light.launch.xml to traffic_light_arbiter.launch.xml, causing some unexpected behavior.
With the changes in this PR, that problem has been solved. The system now works as expected.
Related links
Tests performed
Tested by AWSIM
Notes for reviewers
none
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.