Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix geometric pull out start pose #4362

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 21, 2023

Description

fix geometric pull out start pose

tihs causes wrong turn signal

Related links

Tests performed

not tested

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e07aa8) 15.06% compared to head (c2d3a04) 15.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4362    +/-   ##
========================================
  Coverage   15.06%   15.06%            
========================================
  Files        1508     1508            
  Lines      103774   103758    -16     
  Branches    31705    32022   +317     
========================================
+ Hits        15630    15635     +5     
+ Misses      71124    71102    -22     
- Partials    17020    17021     +1     
Flag Coverage Δ *Carryforward flag
differential 13.52% <0.00%> (?)
total 15.09% <ø> (+0.03%) ⬆️ Carriedforward from 6435c0b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/src/utils/start_planner/geometric_pull_out.cpp 10.34% <0.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HansRobo
Copy link
Member

Merge main branch to run build-and-test-differential (humble, -cuda) with self-hosted runner

@kosuke55 kosuke55 merged commit 365f16e into main Jul 22, 2023
@kosuke55 kosuke55 deleted the fix/geometric_pull_out_winker branch July 22, 2023 06:04
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
…tion#4362)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…tion#4362)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants