-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yabloc_pose_initializer): make yabloc independent of dnn model by default #4296
feat(yabloc_pose_initializer): make yabloc independent of dnn model by default #4296
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4296 +/- ##
==========================================
- Coverage 15.17% 14.18% -0.99%
==========================================
Files 1493 1601 +108
Lines 102950 110095 +7145
Branches 31606 31542 -64
==========================================
- Hits 15623 15619 -4
- Misses 70339 77494 +7155
+ Partials 16988 16982 -6
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
3021e04
to
bd7de47
Compare
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some comments
...ion/yabloc/yabloc_pose_initializer/src/semantic_segmentation/semantic_segmentation_server.py
Outdated
Show resolved
Hide resolved
...ion/yabloc/yabloc_pose_initializer/src/semantic_segmentation/semantic_segmentation_server.py
Outdated
Show resolved
Hide resolved
localization/yabloc/yabloc_pose_initializer/src/camera/marker_module.cpp
Show resolved
Hide resolved
localization/yabloc/yabloc_pose_initializer/src/camera/camera_pose_initializer_core.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Confirmed that both cases works as expected in logging simulator
…y default (autowarefoundation#4296) * care no dnn model exists Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * modify segmentation_srv to inform inference failure Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * add documentation Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix typo Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * ignore DDOWNLOAD Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * make const variable be capital Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * use std::optional rather than reference arg Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Description
This is PR to solve the problems discussed in this discussion https://github.com/orgs/autowarefoundation/discussions/3645.
semantic_segmentation.launch.xml
semantic_segmentation_node.py
Tests performed
I used this dataset to validate with logging_simulator.launch.
(1) With DNN model.
Build
yabloc_pose_initializer
with the following options and verify thatsaved_model
is inautoware/install/yabloc_pose_initializer/share/yabloc_pose_initializer/data
.Then run logging_simulator.launch to verify that the initialization completes properly.
(2) Without DNN model.
Delete
saved_model
inautoware/install/yabloc_pose_initializer/share/yabloc_pose_initializer/data
.Then launch logging_simulator.launch to verify that the initialization completes. This may result in incorrect orientation.
If you specify the initial position with rviz, it should be set correctly.
yabloc_init_without_dnn.mp4
Effects on system behavior
The behavior does not change outside of YabLoc.
Previously, if the model was not downloaded, it could not be initialized.
Now rough initialization can be done without a model.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.