Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): remove unnecessary drivable area generation #4291

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 16, 2023

Description

🤖 Generated by Copilot at 79ca700

Refactor getReferencePath function in utils.cpp to remove unnecessary computation of drivable area. This change is part of migrating the behavior path planner to the new architecture.

Related links

Nothing.

Tests performed

Notes for reviewers

Nothing.

Interface changes

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (48e10b5) 14.87% compared to head (228e43e) 14.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4291      +/-   ##
==========================================
- Coverage   14.87%   14.87%   -0.01%     
==========================================
  Files        1519     1519              
  Lines      105031   105029       -2     
  Branches    32010    32009       -1     
==========================================
- Hits        15628    15627       -1     
  Misses      72331    72331              
+ Partials    17072    17071       -1     
Flag Coverage Δ *Carryforward flag
differential 13.21% <ø> (?)
total 14.87% <ø> (-0.01%) ⬇️ Carriedforward from 48e10b5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 15.61% <ø> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/remove-unnecessary-code branch from 79ca700 to 228e43e Compare August 3, 2023 23:22
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 3, 2023
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Additional note @satoshi-ota :
It was previously reported that start_planner's scenario has failed.
But at the moment, I couldn't reproduce them locally. And evaluator doesn't show any failure anymore. So I think this PR can be merged.

In case there's failure in evaluator tomorrow, I believe we dont need to revert this PR, but instead we should fix start planner's bug.

@satoshi-ota satoshi-ota enabled auto-merge (squash) August 4, 2023 02:52
@satoshi-ota satoshi-ota merged commit b487784 into autowarefoundation:main Aug 4, 2023
@satoshi-ota satoshi-ota deleted the fix/remove-unnecessary-code branch August 4, 2023 02:52
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants