-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): remove unnecessary drivable area generation #4291
refactor(utils): remove unnecessary drivable area generation #4291
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4291 +/- ##
==========================================
- Coverage 14.87% 14.87% -0.01%
==========================================
Files 1519 1519
Lines 105031 105029 -2
Branches 32010 32009 -1
==========================================
- Hits 15628 15627 -1
Misses 72331 72331
+ Partials 17072 17071 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
79ca700
to
228e43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Additional note @satoshi-ota :
It was previously reported that start_planner
's scenario has failed.
But at the moment, I couldn't reproduce them locally. And evaluator doesn't show any failure anymore. So I think this PR can be merged.
In case there's failure in evaluator tomorrow, I believe we dont need to revert this PR, but instead we should fix start planner's bug.
…efoundation#4291) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at 79ca700
Refactor
getReferencePath
function inutils.cpp
to remove unnecessary computation of drivable area. This change is part of migrating the behavior path planner to the new architecture.Related links
Nothing.
Tests performed
Notes for reviewers
Nothing.
Interface changes
Nothing.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.