fix(intersection): fix uninitialized tl_arrow_info variable issue

[soblin]

Description

IntersectionLanelets::tl_arrow_solid_on was uninitialized and was not updated carelessly. Due to this bug when left/right arrow is not solid on when turning left/right each variable was like this when I debug printed.

tl_arrow_solid_on = 0, intersection_lanelets_.value().tl_arrow_solid_on = 144

So for most of the time when the path is covering the intersection this condition was true in every iteration. So first_conflicting_area was null at first, and then initialized to an area after a few iterations.

But if lanelets_.value().tl_arrow_solid_on is left uninitialized to 0, that condition will be applied only at the first time that the corresponding intersection module is activated, so first_conflicting_area was permanently 0.

Related links

https://tier4.atlassian.net/browse/RT1-2875?focusedCommentId=128666&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-128666

Tests performed

no degradation on the CI: https://evaluation.tier4.jp/evaluation/reports/50fcf368-aa63-574e-9de2-89eb26f5e8bc?project_id=prd_jt

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e282c4f) 15.20% compared to head (b094d1f) 15.20%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4283      +/-   ##
==========================================
- Coverage   15.20%   15.20%   -0.01%     
==========================================
  Files        1489     1489              
  Lines      102668   102670       +2     
  Branches    31527    31530       +3     
==========================================
  Hits        15613    15613              
- Misses      70104    70106       +2     
  Partials    16951    16951              

Flag	Coverage Δ		*Carryforward flag
differential	7.59% <0.00%> (?)
total	15.21% <ø> (+<0.01%)	⬆️	Carriedforward from e282c4f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ity_intersection_module/src/scene_intersection.cpp	0.00% <0.00%> (ø)
...ction_module/src/scene_merge_from_private_road.cpp	0.00% <0.00%> (ø)
...behavior_velocity_intersection_module/src/util.cpp	0.00% <0.00%> (ø)
...ior_velocity_intersection_module/src/util_type.hpp	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[soblin]

@shmpwk @takayuki5168 I checked that there is no degradation, so can you approve this PR?