Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): add param for the min confidence of a predicted path #4217

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jul 10, 2023

Description

By default, the out_of_lane module uses the predicted paths of dynamic objects to detect possible collisions when ego exits its current lane.
To avoid false positives caused by improbable predicted paths, this PR adds a parameter to set a minimum confidence.

Corresponding launch PR: autowarefoundation/autoware_launch#440

Tests performed

Tested in Psim.

Before (equivalent to a min confidence of 0.0)

The predicted path with 0.08 confidence is detected to collide with ego when it overlaps the right-side lane.
image

After (with a min confidence of 0.1)

The predicted path with 0.08 confidence is ignored and no collisions are detected.
image

Effects on system behavior

Less false positives when using the out_of_lane module.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2023
@maxime-clem maxime-clem requested a review from takayuki5168 July 10, 2023 08:47
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jul 10, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-add_param_min_predicted_path_probability branch from 5ab0c55 to d2242d8 Compare July 12, 2023 01:57
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (9a73f2c) 14.89% compared to head (7b45871) 14.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4217      +/-   ##
==========================================
- Coverage   14.89%   14.89%   -0.01%     
==========================================
  Files        1520     1520              
  Lines      104882   104885       +3     
  Branches    31952    31955       +3     
==========================================
  Hits        15625    15625              
- Misses      72198    72199       +1     
- Partials    17059    17061       +2     
Flag Coverage Δ *Carryforward flag
differential 24.38% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from 9a73f2c

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...vior_velocity_out_of_lane_module/src/decisions.cpp 1.15% <0.00%> (-0.01%) ⬇️
...havior_velocity_out_of_lane_module/src/manager.cpp 20.93% <0.00%> (-1.03%) ⬇️
...behavior_velocity_out_of_lane_module/src/types.hpp 22.72% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 self-assigned this Aug 1, 2023
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2023
@maxime-clem maxime-clem enabled auto-merge (squash) August 1, 2023 13:13
@maxime-clem maxime-clem merged commit f78ee7d into autowarefoundation:main Aug 1, 2023
@maxime-clem maxime-clem deleted the feat/out_of_lane-add_param_min_predicted_path_probability branch August 1, 2023 21:59
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 29, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
…th (autowarefoundation#4217)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants