-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(out_of_lane): add param for the min confidence of a predicted path #4217
Merged
maxime-clem
merged 5 commits into
autowarefoundation:main
from
maxime-clem:feat/out_of_lane-add_param_min_predicted_path_probability
Aug 1, 2023
Merged
feat(out_of_lane): add param for the min confidence of a predicted path #4217
maxime-clem
merged 5 commits into
autowarefoundation:main
from
maxime-clem:feat/out_of_lane-add_param_min_predicted_path_probability
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jul 10, 2023
4 tasks
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Jul 10, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
force-pushed
the
feat/out_of_lane-add_param_min_predicted_path_probability
branch
from
July 12, 2023 01:57
5ab0c55
to
d2242d8
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4217 +/- ##
==========================================
- Coverage 14.89% 14.89% -0.01%
==========================================
Files 1520 1520
Lines 104882 104885 +3
Branches 31952 31955 +3
==========================================
Hits 15625 15625
- Misses 72198 72199 +1
- Partials 17059 17061 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Aug 1, 2023
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 1, 2023
maxime-clem
deleted the
feat/out_of_lane-add_param_min_predicted_path_probability
branch
August 1, 2023 21:59
felixf4xu
pushed a commit
to felixf4xu/autoware.universe
that referenced
this pull request
Aug 2, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
t4-x2
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 29, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Closed
4 tasks
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
…th (autowarefoundation#4217) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, the
out_of_lane
module uses the predicted paths of dynamic objects to detect possible collisions when ego exits its current lane.To avoid false positives caused by improbable predicted paths, this PR adds a parameter to set a minimum confidence.
Corresponding launch PR: autowarefoundation/autoware_launch#440
Tests performed
Tested in Psim.
Before (equivalent to a min confidence of
0.0
)The predicted path with
0.08
confidence is detected to collide with ego when it overlaps the right-side lane.After (with a min confidence of
0.1
)The predicted path with
0.08
confidence is ignored and no collisions are detected.Effects on system behavior
Less false positives when using the
out_of_lane
module.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.