Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ad_api_adaptors): fix readme to remove unused service #4117

Merged

Conversation

isamu-takagi
Copy link
Contributor

Description

Fix readme to remove unused service.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Jun 29, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5bc699b) 14.35% compared to head (bb8abbe) 14.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4117      +/-   ##
==========================================
- Coverage   14.35%   14.35%   -0.01%     
==========================================
  Files        1569     1569              
  Lines      108002   108001       -1     
  Branches    31250    31250              
==========================================
- Hits        15500    15499       -1     
  Misses      75648    75648              
  Partials    16854    16854              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.35% <ø> (-0.01%) ⬇️ Carriedforward from 5bc699b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/src/scene_module/lane_change/normal.cpp 4.69% <ø> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 53b1347 into autowarefoundation:main Jun 29, 2023
@isamu-takagi isamu-takagi deleted the docs/fix-removed-service branch November 22, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants