Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(avoidance): parameterize magic number #4116

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 29, 2023

Description

🤖 Generated by Copilot at f2348f0

This pull request refactors the avoidance module of the behavior path planner to use a new parameter lateral_avoid_check_threshold for checking the lateral shift of the ego vehicle during avoidance maneuvers. It also removes the unused variable avoiding_now and replaces it with the isShifted method. The change affects the data structures, the logic, the configuration, and the debugging of the avoidance module.

Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#426

Tests performed

Effects on system behavior

Nothing. Just refactoring.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (9dad706) 15.06% compared to head (164f934) 15.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4116      +/-   ##
==========================================
- Coverage   15.06%   15.00%   -0.07%     
==========================================
  Files        1508     1512       +4     
  Lines      103774   104408     +634     
  Branches    31705    32059     +354     
==========================================
+ Hits        15630    15662      +32     
- Misses      71124    71675     +551     
- Partials    17020    17071      +51     
Flag Coverage Δ *Carryforward flag
differential 13.51% <0.00%> (?)
total 15.06% <ø> (+<0.01%) ⬆️ Carriedforward from 5183938

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...e/behavior_path_planner/utils/avoidance/helper.hpp 24.27% <0.00%> (-0.24%) ⬇️
..._path_planner/src/marker_utils/avoidance/debug.cpp 4.59% <0.00%> (+0.01%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.94% <0.00%> (-0.06%) ⬇️
...ath_planner/src/scene_module/avoidance/manager.cpp 6.81% <0.00%> (-0.13%) ⬇️
...behavior_velocity_out_of_lane_module/src/debug.cpp 55.10% <ø> (+1.10%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota marked this pull request as ready for review June 30, 2023 01:11
@satoshi-ota satoshi-ota force-pushed the refactor/remove-magic-number branch 3 times, most recently from a1f1433 to fc35b32 Compare July 6, 2023 00:38
@satoshi-ota satoshi-ota force-pushed the refactor/remove-magic-number branch from fc35b32 to 1c318fc Compare July 19, 2023 04:16
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota force-pushed the refactor/remove-magic-number branch 2 times, most recently from 9c25a71 to 229e162 Compare July 21, 2023 09:12
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the refactor/remove-magic-number branch from 229e162 to 164f934 Compare July 21, 2023 22:41
@satoshi-ota satoshi-ota merged commit cbaaa69 into autowarefoundation:main Jul 22, 2023
@satoshi-ota satoshi-ota deleted the refactor/remove-magic-number branch July 22, 2023 06:13
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants