-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance): parameterize magic number #4116
refactor(avoidance): parameterize magic number #4116
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4116 +/- ##
==========================================
- Coverage 15.06% 15.00% -0.07%
==========================================
Files 1508 1512 +4
Lines 103774 104408 +634
Branches 31705 32059 +354
==========================================
+ Hits 15630 15662 +32
- Misses 71124 71675 +551
- Partials 17020 17071 +51
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
a1f1433
to
fc35b32
Compare
fc35b32
to
1c318fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9c25a71
to
229e162
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
229e162
to
164f934
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖 Generated by Copilot at f2348f0
This pull request refactors the avoidance module of the behavior path planner to use a new parameter
lateral_avoid_check_threshold
for checking the lateral shift of the ego vehicle during avoidance maneuvers. It also removes the unused variableavoiding_now
and replaces it with theisShifted
method. The change affects the data structures, the logic, the configuration, and the debugging of the avoidance module.Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#426
Tests performed
Effects on system behavior
Nothing. Just refactoring.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.