fix(velocity_smoother): add acc limit on manual driving #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
TakaHoribe
requested review from
rej55,
mkuri,
purewater0901 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4113 +/- ##
=======================================
Coverage 14.35% 14.35%
=======================================
Files 1569 1569
Lines 107995 107997 +2
Branches 31250 31251 +1
=======================================
+ Hits 15499 15501 +2
Misses 75642 75642
Partials 16854 16854
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
tkimura4
approved these changes
Jun 29, 2023
purewater0901
approved these changes
Jun 30, 2023
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 3, 2023
…dation#4113) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an acceleration limit to enable "engage on manual driving when accelerating".
Tests performed
Run psim, and real vehicle experiment
Effects on system behavior
enable "engage on manual driving when accelerating".
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.