Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_smoother): consider velocity limit on manual driving #4010

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 19, 2023

Description

Take the velocity limit in the velocity planning when manual mode.

Related links

Tests performed

related to #3948

Notes for reviewers

None

Interface changes

None

Effects on system behavior

Behavior in "engage on manual driving" will slightly change

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ving

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from rej55, mkuri, purewater0901 and a team as code owners June 19, 2023 05:32
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (15325f6) 14.41% compared to head (c426b27) 14.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4010   +/-   ##
=======================================
  Coverage   14.41%   14.41%           
=======================================
  Files        1456     1456           
  Lines      102763   102764    +1     
  Branches    29785    29785           
=======================================
+ Hits        14815    14816    +1     
  Misses      71765    71765           
  Partials    16183    16183           
Flag Coverage Δ *Carryforward flag
differential 11.61% <100.00%> (?)
total 14.41% <ø> (ø) Carriedforward from 15325f6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 28.17% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe enabled auto-merge (squash) June 19, 2023 06:57
@TakaHoribe TakaHoribe merged commit 3c320a0 into autowarefoundation:main Jun 19, 2023
@TakaHoribe TakaHoribe deleted the smoother-manual-plan-update branch June 19, 2023 07:33
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…ving (autowarefoundation#4010)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants