-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): enable delay lane change when necessary #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
zulfaqar-azmi-t4 and
a team
as code owners
June 15, 2023 15:02
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jun 15, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3991 +/- ##
==========================================
- Coverage 14.37% 14.36% -0.01%
==========================================
Files 1566 1566
Lines 107726 107778 +52
Branches 31175 31204 +29
==========================================
Hits 15482 15482
- Misses 75420 75464 +44
- Partials 16824 16832 +8
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…undation/autoware.universe into feat/enable-delay-lane-change
Signed-off-by: yutaka <purewater0901@gmail.com>
rej55
reviewed
Jun 26, 2023
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
rej55
approved these changes
Jun 26, 2023
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 27, 2023
…utowarefoundation#3991) * feat(behavior_path_planner): enable delay lane change when necessary Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): add a function to judge a parked vehicle Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * Update planning/behavior_path_planner/src/utils/lane_change/utils.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * update name Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
7 tasks
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 27, 2023
…utowarefoundation#3991) (#623) * feat(behavior_path_planner): enable delay lane change when necessary * update * update * feat(behavior_path_planner): add a function to judge a parked vehicle * update * update * update * update * update * update * update * update * Update planning/behavior_path_planner/src/utils/lane_change/utils.cpp * update name --------- Signed-off-by: yutaka <purewater0901@gmail.com> Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current lane change module performs lane change even though it has an object on the target lanes. In this PR, I created a new safety check module that enables the lane change to deactivate when it has enough space to do lane change after the target lane.
Launch PR
An illustrative example is shown in the following picture.
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.