Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): enable delay lane change when necessary #3991

Merged
merged 21 commits into from
Jun 26, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jun 15, 2023

Description

The current lane change module performs lane change even though it has an object on the target lanes. In this PR, I created a new safety check module that enables the lane change to deactivate when it has enough space to do lane change after the target lane.

Launch PR

An illustrative example is shown in the following picture.
image

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 marked this pull request as draft June 15, 2023 15:02
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 4.70% and project coverage change: -0.01 ⚠️

Comparison is base (7b6bff2) 14.37% compared to head (64ffb36) 14.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3991      +/-   ##
==========================================
- Coverage   14.37%   14.36%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      107726   107778      +52     
  Branches    31175    31204      +29     
==========================================
  Hits        15482    15482              
- Misses      75420    75464      +44     
- Partials    16824    16832       +8     
Flag Coverage Δ *Carryforward flag
differential 13.59% <4.76%> (?)
total 14.36% <0.00%> (-0.01%) ⬇️ Carriedforward from 7b6b083

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 16.27% <ø> (-0.39%) ⬇️
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (-50.00%) ⬇️
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.37% <0.00%> (-0.08%) ⬇️
...path_planner/src/marker_util/lane_change/debug.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.68% <0.00%> (ø)
...ath_planner/src/scene_module/avoidance/manager.cpp 14.28% <0.00%> (ø)
...ehavior_path_planner/src/utils/avoidance/utils.cpp 5.81% <0.00%> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.40% <0.00%> (-0.04%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

purewater0901 and others added 14 commits June 16, 2023 02:23
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
…undation/autoware.universe into feat/enable-delay-lane-change
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 marked this pull request as ready for review June 19, 2023 05:43
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901 and others added 3 commits June 26, 2023 16:24
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 enabled auto-merge (squash) June 26, 2023 07:47
@purewater0901 purewater0901 disabled auto-merge June 26, 2023 08:02
@purewater0901 purewater0901 disabled auto-merge June 26, 2023 08:03
@rej55 rej55 merged commit a31dfdb into main Jun 26, 2023
@rej55 rej55 deleted the feat/enable-delay-lane-change branch June 26, 2023 10:17
rej55 added a commit to tier4/autoware.universe that referenced this pull request Jun 27, 2023
…utowarefoundation#3991)

* feat(behavior_path_planner): enable delay lane change when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): add a function to judge a parked vehicle

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* Update planning/behavior_path_planner/src/utils/lane_change/utils.cpp

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

* update name

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 27, 2023
…utowarefoundation#3991) (#623)

* feat(behavior_path_planner): enable delay lane change when necessary



* update



* update



* feat(behavior_path_planner): add a function to judge a parked vehicle



* update



* update



* update



* update



* update



* update



* update



* update



* Update planning/behavior_path_planner/src/utils/lane_change/utils.cpp



* update name



---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants