Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): remove lateral offset check for finish start planner #3931

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 9, 2023

Description

with #3928, approved module can be finished without considering candidate module, so remove lateral and yaw deviation check for finishing module.

Related links

#3928

Tests performed

psim

kepp_running_candidate-2023-06-09_20.40.12.mp4

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 9, 2023
…tart planner

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/remove_lateral_check_start_planner_finish branch from feb05ad to 9302daa Compare June 9, 2023 12:20
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.99 🎉

Comparison is base (21b6403) 14.43% compared to head (9302daa) 15.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3931      +/-   ##
==========================================
+ Coverage   14.43%   15.43%   +0.99%     
==========================================
  Files        1456     1350     -106     
  Lines      102536    95927    -6609     
  Branches    29720    29716       -4     
==========================================
  Hits        14806    14806              
+ Misses      71575    64966    -6609     
  Partials    16155    16155              
Flag Coverage Δ *Carryforward flag
differential 13.05% <0.00%> (?)
total 15.43% <ø> (+0.99%) ⬆️ Carriedforward from 21b6403

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...cene_module/start_planner/start_planner_module.cpp 5.86% <ø> (+0.06%) ⬆️

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 18a5c5f into main Jun 19, 2023
@kosuke55 kosuke55 deleted the feat/remove_lateral_check_start_planner_finish branch June 19, 2023 10:06
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jun 19, 2023
…tart planner (autowarefoundation#3931)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jun 19, 2023
…tart planner (autowarefoundation#3931)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants