Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(start_planner): rename pull out to start planner #3908

Merged
merged 1 commit into from
Jun 7, 2023
Merged

refactor(start_planner): rename pull out to start planner #3908

merged 1 commit into from
Jun 7, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 6, 2023 •
edited
Loading

Description

In #3805 support normal lane, so rename pull out to start planner

Related links

rename

Tests performed

psim auto mode

psim with foa

start_planner_foa-2023-06-07_16.09.15.mp4

tier4 internal scenario test 1334/1372->1334/1372

Notes for reviewers

Interface changes

topic names change *pull_over* -> *start_planner*

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Jun 6, 2023
@kosuke55
refactor(start_planner): rename pull out to start planner
a43a1e4 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the refactor/rename_start_planner branch from 185226c to a43a1e4 Compare June 6, 2023 07:38
isamu-takagi
isamu-takagi approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for following packages.

  • tier4_state_rviz_plugin
  • default_ad_api
  • ad_api_visualizers

This was referenced Jun 6, 2023
Merged
Merged
Merged
Merged
yukkysaito
yukkysaito approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yukke42
yukke42 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for lidar_centerpoint

@kosuke55 kosuke55 mentioned this pull request Jun 7, 2023
Merged
7 tasks
@kosuke55 kosuke55 merged commit 8c9f9e4 into main Jun 7, 2023
@kosuke55 kosuke55 deleted the refactor/rename_start_planner branch June 7, 2023 11:21
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jun 8, 2023
Merged
@kosuke55 kosuke55 mentioned this pull request Jun 8, 2023
Closed
3 tasks
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jun 8, 2023
@kosuke55
refactor(start_planner): rename pull out to start planner (autowarefo…
dd87734 
…undation#3908)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 mentioned this pull request Jun 8, 2023
Merged
7 tasks
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 8, 2023
@kosuke55 @kyoichi-sugahara
refactor(start_planner): rename pull out to start planner (#565)
d1a1fde 
* refactor(pull_out): consolidate similar function (autowarefoundation#3803)

* consolidate planWithPriority function

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add comments

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* refactoring

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* refactoring

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change arg type

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/scene_module/pull_out/pull_out_module.cpp

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/pull_out/pull_out_module.hpp

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

* refactor(start_planner): rename pull out to start planner (autowarefoundation#3908)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@yukke42 yukke42 yukke42 approved these changes

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@rej55 rej55 rej55 approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@tkhmy tkhmy Awaiting requested review from tkhmy

@yabuta yabuta Awaiting requested review from yabuta

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@knzo25 knzo25 Awaiting requested review from knzo25

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@h-ohta h-ohta Awaiting requested review from h-ohta

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kosuke55 @yukkysaito @rej55 @TakaHoribe @yukke42 @isamu-takagi