Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): check lateral offset at lc finish judgement #3861

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 30, 2023

Description

Current implementation, lane change module checks only traveling distance to judge the lane change maneuver is finished.

In this PR, I add lateral offset condition to the judgement. The module judges lc is finished only when the lateral offset between the ego and target lane is less than finish_judge_lateral_threshold (default: 0.2 [m]).

This PR must be merged after ⬇️
autowarefoundation/autoware_launch#375

Tests performed

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4856894) 14.08% compared to head (7556444) 14.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3861    +/-   ##
========================================
  Coverage   14.08%   14.08%            
========================================
  Files        1441     1441            
  Lines      101722   101847   +125     
  Branches    27086    27179    +93     
========================================
+ Hits        14330    14350    +20     
- Misses      71701    71790    +89     
- Partials    15691    15707    +16     
Flag Coverage Δ *Carryforward flag
differential 13.18% <0.00%> (?)
total 14.08% <ø> (+<0.01%) ⬆️ Carriedforward from 4856894

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.96% <0.00%> (-0.05%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 3.95% <0.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 0f52cee into autowarefoundation:main May 30, 2023
@satoshi-ota satoshi-ota deleted the feat/check-lateral-offset-lc-finish branch May 30, 2023 08:34
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 30, 2023
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 30, 2023
feat(lane_change): check lateral offset at lc finish judgement (autowarefoundation#3861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants