-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): check lateral offset at lc finish judgement #3861
feat(lane_change): check lateral offset at lc finish judgement #3861
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3861 +/- ##
========================================
Coverage 14.08% 14.08%
========================================
Files 1441 1441
Lines 101722 101847 +125
Branches 27086 27179 +93
========================================
+ Hits 14330 14350 +20
- Misses 71701 71790 +89
- Partials 15691 15707 +16
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…arefoundation#3861) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
feat(lane_change): check lateral offset at lc finish judgement (autowarefoundation#3861)
Description
Current implementation, lane change module checks only traveling distance to judge the lane change maneuver is finished.
In this PR, I add lateral offset condition to the judgement. The module judges lc is finished only when the lateral offset between the ego and target lane is less than
finish_judge_lateral_threshold
(default: 0.2 [m]).This PR must be merged after ⬇️
autowarefoundation/autoware_launch#375
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.