-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): disable peeking while collision is detected #3765
Merged
soblin
merged 9 commits into
autowarefoundation:main
from
soblin:feat/disable-peeking-while-collision-detection
May 23, 2023
Merged
feat(intersection): disable peeking while collision is detected #3765
soblin
merged 9 commits into
autowarefoundation:main
from
soblin:feat/disable-peeking-while-collision-detection
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 19, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3765 +/- ##
=======================================
Coverage 14.13% 14.13%
=======================================
Files 1438 1438
Lines 101342 101338 -4
Branches 27015 27008 -7
=======================================
Hits 14321 14321
+ Misses 71332 71328 -4
Partials 15689 15689
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
soblin
force-pushed
the
feat/disable-peeking-while-collision-detection
branch
3 times, most recently
from
May 22, 2023 09:55
37e88bb
to
1319feb
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
* fix(intersection): use 0 offset peeking line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use braking distance Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add pass_judge_wall_pose marker Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep detection if ego is between stopline and pass judge line and velocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * modify condition Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use 0.0s for delay response time Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * right turn scenario passes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * find all stop line candidates at first in order Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use keep_detection_vel for staticPassJudgeLine Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This reverts commit 7fd41ab. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This reverts commit a6d7fb6. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
feat/disable-peeking-while-collision-detection
branch
from
May 22, 2023 10:03
1319feb
to
9f6dfce
Compare
takayuki5168
approved these changes
May 23, 2023
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
May 23, 2023
…warefoundation#3765) * feat(intersection): disable peeking while collision is detected Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * preempt PR3711 (#11) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fixed !has_collision Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Preempt PR3711(2) (#13) * fix(intersection): use 0 offset peeking line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use braking distance Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * add pass_judge_wall_pose marker Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * keep detection if ego is between stopline and pass judge line and velocity is below threshold Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * modify condition Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use 0.0s for delay response time Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * right turn scenario passes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * find all stop line candidates at first in order Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * use keep_detection_vel for staticPassJudgeLine Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * added COLLISION_DETECTED state Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * po Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Revert "Preempt PR3711(2) (#13)" This reverts commit 7fd41ab. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Revert "preempt PR3711 (#11)" This reverts commit a6d7fb6. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * call setSafe() regardless of occlusion_stop_required Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When occlusion and collision is detected at the same time, peeking for occlusion clearance is not executed.
Related links
https://tier4.atlassian.net/browse/RT1-2242
Tests performed
Before this PR
Before this PR
at [00:06] ego does not stop at the intersection stopline
before_PR.mp4
After this PR
ego keeps stopping until the oncoming cars pass through the junction.
2023-05-22_18.59.38.mp4
Notes for reviewers
Interface changes
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.