Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): add margins for avoidance #3759

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 18, 2023

Description

Prepare parameters to time margins to avoid before and after passing by obstacles in dynamic_avoidance.

Tests performed

planning simulator

Effects on system behavior

No behavior change

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label May 18, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (206bc1e) 14.46% compared to head (a68fc23) 14.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3759      +/-   ##
==========================================
+ Coverage   14.46%   14.51%   +0.04%     
==========================================
  Files        1432     1432              
  Lines      100828   101686     +858     
  Branches    29764    30428     +664     
==========================================
+ Hits        14585    14759     +174     
- Misses      70394    70957     +563     
- Partials    15849    15970     +121     
Flag Coverage Δ *Carryforward flag
differential 13.25% <0.00%> (?)
total 14.46% <ø> (+<0.01%) ⬆️ Carriedforward from 206bc1e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.16% <0.00%> (-0.24%) ⬇️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit b244c2d into autowarefoundation:main May 19, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-margins branch May 19, 2023 07:30
j4tfwm6z pushed a commit to tier4/autoware.universe that referenced this pull request May 25, 2023
…n#3759)

* feat(dynamic_avoidance): add margins for avoidance

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* reconfigurable parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2023
…n#3759)

* feat(dynamic_avoidance): add margins for avoidance

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* reconfigurable parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z pushed a commit to tier4/autoware.universe that referenced this pull request Jun 22, 2023
…n#3759)

* feat(dynamic_avoidance): add margins for avoidance

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* reconfigurable parameters

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants