Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): empty pointcloud bug #373

Merged

Conversation

0x126
Copy link
Contributor

@0x126 0x126 commented Feb 10, 2022

Related Issue(required)

Description(required)

  • Fixed a bug that caused some modules to crash when the input point cloud was empty.

Review Procedure(required)

  • Play rosbags and check pointclouds and rosout

Related PR(optional)

#253

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@0x126 0x126 force-pushed the fix/empty_pointcloyd_bug branch from d1473ba to b8df615 Compare February 10, 2022 09:41
Signed-off-by: Shinnosuke Hirakawa <shinnosuke.hirakawa@tier4.jp>
@0x126 0x126 force-pushed the fix/empty_pointcloyd_bug branch from b8df615 to b1d74aa Compare February 10, 2022 09:41
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #373 (b1d74aa) into tier4/proposal (eb599ae) will decrease coverage by 9.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tier4/proposal    #373      +/-   ##
=================================================
- Coverage            9.32%   0.00%   -9.33%     
=================================================
  Files                 701      42     -659     
  Lines               48973    2815   -46158     
  Branches             5818       0    -5818     
=================================================
- Hits                 4566       0    -4566     
+ Misses              40594    2815   -37779     
+ Partials             3813       0    -3813     
Impacted Files Coverage Δ
.../src/concatenate_data/concatenate_data_nodelet.cpp 0.00% <0.00%> (ø)
...lier_filter/dual_return_outlier_filter_nodelet.cpp 0.00% <0.00%> (ø)
...lization/src/traffic_light_map_visualizer/main.cpp
...ng_simulator/vehicle_model/sim_model_interface.cpp
...anner/include/scene_module/traffic_light/scene.hpp
...c/tracker/model/pedestrian_and_bicycle_tracker.cpp
map/lanelet2_extension/lib/detection_area.cpp
...tem/system_monitor/src/mem_monitor/mem_monitor.cpp
...test/src/test_planning_error_monitor_functions.cpp
... and 652 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb599ae...b1d74aa. Read the comment docs.

@0x126 0x126 requested review from 1222-takeshi and removed request for 1222-takeshi February 10, 2022 10:20
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi
Copy link
Contributor

@0x126
Could you write release note?

@kenji-miyake
Copy link
Contributor

@1222-takeshi Since the release notes are for TIER IV, we'll manage them in sync PRs in tier4 org like this: tier4#11

@1222-takeshi 1222-takeshi merged commit 45816fc into autowarefoundation:tier4/proposal Feb 15, 2022
1222-takeshi referenced this pull request in tier4/autoware.universe Feb 24, 2022
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…dation#373)

feat(avoidance): additional offset for perception noise

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
* Use apt-get -y

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Don't free disk space

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants