-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radar_converter_outputs): add DetectedObjects output #3450
fix(radar_converter_outputs): add DetectedObjects output #3450
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
…utoware.universe into fix/radar_converter_outputs
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
==========================================
- Coverage 14.52% 12.45% -2.08%
==========================================
Files 1287 1381 +94
Lines 91309 95545 +4236
Branches 28616 27263 -1353
==========================================
- Hits 13260 11896 -1364
- Misses 63793 71062 +7269
+ Partials 14256 12587 -1669
*This pull request uses carry forward flags. Click here to find out more.
... and 267 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@scepter914 Sorry I missed confirming the influence. |
@miursh |
…ndation#3450) * fix(radar_tracks_msgs_converter_node): add DetectedObjects output Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * fix(radar_tracks_msgs_converter_node): add DetectedObjects output Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * update launcher Signed-off-by: scepter914 <scepter914@gmail.com> --------- Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Add
DetectedObjects
output intoradar_converter_outputs
to custom radar faraway detection pipeline.After this PR is merged, I'll change the input interface of
radar_fusion_to_detected_object
.Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.