Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): move ego data getters to abstract class #3422

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 14, 2023

Description

move getter functions of ego's data (pose, position, twist, speed) to abstract class.

Tests performed

Confirmed that build just passed since this is not a big change.

Effects on system behavior

No behavior change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 14, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review April 14, 2023 16:34
@takayuki5168
Copy link
Contributor Author

@purewater0901 This is a small refactoring PR. Could you review the PR.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (79f7dc4) 13.15% compared to head (76dfd13) 13.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   13.15%   13.15%   -0.01%     
==========================================
  Files        1382     1382              
  Lines       97085    97306     +221     
  Branches    28099    28239     +140     
==========================================
+ Hits        12771    12797      +26     
- Misses      70624    70778     +154     
- Partials    13690    13731      +41     
Flag Coverage Δ *Carryforward flag
differential 12.22% <0.00%> (?)
total 13.14% <ø> (-0.01%) ⬇️ Carriedforward from 79f7dc4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...th_planner/scene_module/avoidance_by_lc/module.hpp 0.00% <ø> (ø)
...ane_change/external_request_lane_change_module.hpp 0.00% <ø> (ø)
...er/scene_module/lane_change/lane_change_module.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 38.04% <0.00%> (-1.73%) ⬇️
...nner/scene_module/side_shift/side_shift_module.hpp 100.00% <ø> (+33.33%) ⬆️
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <ø> (ø)
...ane_change/external_request_lane_change_module.cpp 14.74% <ø> (+0.72%) ⬆️
...rc/scene_module/lane_change/lane_change_module.cpp 9.15% <ø> (+0.45%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 2b874a1 into autowarefoundation:main Apr 17, 2023
@takayuki5168 takayuki5168 deleted the refactor/ego-data-getter branch April 17, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants