-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): move ego data getters to abstract class #3422
refactor(behavior_path_planner): move ego data getters to abstract class #3422
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@purewater0901 This is a small refactoring PR. Could you review the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3422 +/- ##
==========================================
- Coverage 13.15% 13.15% -0.01%
==========================================
Files 1382 1382
Lines 97085 97306 +221
Branches 28099 28239 +140
==========================================
+ Hits 12771 12797 +26
- Misses 70624 70778 +154
- Partials 13690 13731 +41
*This pull request uses carry forward flags. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Description
move getter functions of ego's data (pose, position, twist, speed) to abstract class.
Tests performed
Confirmed that build just passed since this is not a big change.
Effects on system behavior
No behavior change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.