-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): add dynamic obstacle avoidance module #3415
feat(behavior_path_planner): add dynamic obstacle avoidance module #3415
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
acf6198
to
58c9bee
Compare
planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp
Outdated
Show resolved
Hide resolved
...er/include/behavior_path_planner/scene_module/dynamic_avoidance/dynamic_avoidance_module.hpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/docs/behavior_path_planner_dynamic_avoidance_design.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add config in behavior_path_planner/config/~
?
…nce/dynamic_avoidance_module.cpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…cene_module/dynamic_avoidance/dynamic_avoidance_module.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…mic_avoidance_design.md Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
- Coverage 14.07% 14.05% -0.02%
==========================================
Files 1398 1400 +2
Lines 97962 98777 +815
Branches 29084 29636 +552
==========================================
+ Hits 13789 13886 +97
- Misses 69500 70132 +632
- Partials 14673 14759 +86
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…utowarefoundation#3415) * implement dynamic avoidance module Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix spell Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_path_planner/src/scene_module/dynamic_avoidance/dynamic_avoidance_module.cpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> * Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/dynamic_avoidance/dynamic_avoidance_module.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> * Update planning/behavior_path_planner/docs/behavior_path_planner_dynamic_avoidance_design.md Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> * dealt with review Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * disable dynamic avoidance with old architecture, and pass build CI Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
This feature is under development, and disabled by default.
NOTE:
https://github.com/autowarefoundation/autoware_launch/blob/5910b08f7742d78ac5f1ade182d470032e40e398/autoware_launch/config/planning/scenario_planning/lane_driving/motion_planning/obstacle_avoidance_planner/obstacle_avoidance_planner.param.yaml#L7
Added a dynamic avoidance module for avoiding dynamic obstacles which are running on the road.
In the current implementation, by extracting the dynamic obstacles to avoid from the drivable area, the motion planner plans the trajectory to avoid the obstacles.
Screencast.from.2023.04.27.17.49.10.webm
TODO
small TODOs
Related links
launcher: autowarefoundation/autoware_launch#299
Tests performed
In the planning simulator, in a simple case, it's working correctly.
Though the steering controller is a little bit unstable.
Notes for reviewers
Interface changes
Nothing
Effects on system behavior
Dynamic avoidance feature can be enabled.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.