Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compare_map_segmentation): fix namespace block syntax error #3374

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

danieltaciak
Copy link
Contributor

@danieltaciak danieltaciak commented Apr 12, 2023

Description

Fixed syntax error in multi_voxel_grid_map_update header:
Namespace block should not end with semicolon as stated in cpp reference:
https://en.cppreference.com/w/cpp/language/namespace

This error breaks the build with some c++ compiler versions

Tests performed

Built on aarch64 and x86 platforms.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Taciak <daniel.taciak@dynamics-regensburg.de>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Apr 12, 2023
@danieltaciak danieltaciak marked this pull request as ready for review April 12, 2023 07:48
@danieltaciak danieltaciak requested review from amc-nu, yukkysaito and a team as code owners April 12, 2023 07:48
@badai-nguyen
Copy link
Contributor

@danieltaciak Thank you for your PR. FYI, I'm also working on compare map here #3277 and going to refactor multi_voxel_grid_map_update.hpp .

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito enabled auto-merge (squash) April 17, 2023 05:38
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3aead0d) 12.33% compared to head (9f0ecd4) 12.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3374   +/-   ##
=======================================
  Coverage   12.33%   12.33%           
=======================================
  Files        1381     1381           
  Lines       96627    96627           
  Branches    27925    27925           
=======================================
  Hits        11919    11919           
  Misses      72079    72079           
  Partials    12629    12629           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 12.33% <ø> (ø) Carriedforward from 3aead0d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e_map_segmentation/multi_voxel_grid_map_update.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yukkysaito yukkysaito merged commit 053753b into autowarefoundation:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants