Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route_handler): add route clear function #3338

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 10, 2023

Description

Add route clear function

🤖 Generated by Copilot at 33f1afc

Added a clearRoute function to the RouteHandler class to reset the route state. This function is used by the RouteGenerator class to handle new or invalid route requests.

Related Links: #3334

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.80 🎉

Comparison is base (91ac2bc) 12.33% compared to head (e2349d1) 13.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3338      +/-   ##
==========================================
+ Coverage   12.33%   13.14%   +0.80%     
==========================================
  Files        1379     1280      -99     
  Lines       96686    90733    -5953     
  Branches    27971    27969       -2     
==========================================
  Hits        11928    11928              
+ Misses      72090    66135    -5955     
- Partials    12668    12670       +2     
Flag Coverage Δ *Carryforward flag
differential 4.98% <0.00%> (?)
total 13.16% <ø> (+0.83%) ⬆️ Carriedforward from b33d4bb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nclude/behavior_path_planner/util/safety_check.hpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 100.00% <ø> (+16.66%) ⬆️
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
...ane_change/external_request_lane_change_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)
...ng/behavior_path_planner/src/util/safety_check.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 9.96% <ø> (+1.33%) ⬆️
planning/route_handler/src/route_handler.cpp 11.33% <0.00%> (-0.13%) ⬇️

... and 102 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 4a84fb8 into main Apr 10, 2023
@purewater0901 purewater0901 deleted the feat/add-route-clear-function branch April 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants