feat(autonomous_emergency_braking): keep collision information for user specified seconds #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er specified seconds
github-actions
bot
added
the
component:control
h-ohta
requested review from
TakaHoribe,
purewater0901 and
a team
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
+ Coverage 12.41% 12.49% +0.08%
==========================================
Files 1368 1365 -3
Lines 96123 94695 -1428
Branches 27697 26745 -952
==========================================
- Hits 11931 11835 -96
+ Misses 71526 70343 -1183
+ Partials 12666 12517 -149
*This pull request uses carry forward flags. Click here to find out more.
... and 46 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 10, 2023
…er specified seconds (autowarefoundation#3292) * feat(autonomous_emergency_braking): keep collision information for user specified seconds * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 13, 2023
…warefoundation#2793, autowarefoundation#3186, autowarefoundation#3248, autowarefoundation#3292) (#330) * feat(control): add autonomous emergency braking module (autowarefoundation#2793) * fix build error * ci(pre-commit): autofix * fix: fix lookup symbol error * fix(autonomous_emergency_braking): fix typo (autowarefoundation#3186) Update node.cpp * fix(autonomous_emergency_braking): publish debug marker on base_link frame (autowarefoundation#3248) * feat(autonomous_emergency_braking): keep collision information for user specified seconds (autowarefoundation#3292) * feat(autonomous_emergency_braking): keep collision information for user specified seconds * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CollisionDataKeepercollision_keeping_sec, default is 0.0Related links
Tests performed
I confirmed it works in my environment.
green point: ObjectData
red point: Collision decided Point
https://user-images.githubusercontent.com/9547070/230254191-00cfe377-d48e-4aa3-bffe-19658f8d1d09.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.