Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tier4_perception_launch): add custom parameters for roi_cluster_fusion #3281

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Apr 5, 2023

Description

I made it possible to change parameters from autoware_launch that are highly likely to be modified depending on their usage.

Related links

Tests performed

I confirmed that the recognition module launched successfully.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…_fusion

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from miursh, yukkysaito and a team as code owners April 5, 2023 10:42
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Apr 5, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 enabled auto-merge (squash) April 5, 2023 10:47
@tkimura4 tkimura4 merged commit 536d803 into autowarefoundation:main Apr 5, 2023
@tkimura4 tkimura4 deleted the chore/add_param_to_roi branch April 5, 2023 11:04
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…_fusion (autowarefoundation#3281)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants