Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader): add grid coordinates for partial/differential map load #3205

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Mar 29, 2023

Sample split map is here

sample-map-rosbag_split.zip
Here is a sample map split with metadata.yaml

Description

Please see https://github.com/orgs/autowarefoundation/discussions/3328 for the detail

You can use https://github.com/MapIV/pointcloud_divider for dividing pointcloud map into grids

Please find a how-to in updated readme
image

Should be merged after:

Related links

Tests performed

  • Generate a divided pointcloud map with a given tool
  • Load the pointcloud map and its metadata with logging_simulator

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested review from mitsudome-r, RyuYamamoto and a team as code owners March 29, 2023 07:19
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Mar 29, 2023
@kminoda
Copy link
Contributor Author

kminoda commented Mar 29, 2023

@RyuYamamoto Sorry again, this is the latest PR 🙏

pre-commit-ci bot and others added 2 commits March 29, 2023 07:21
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda
Copy link
Contributor Author

kminoda commented Mar 30, 2023

@yukkysaito @YamatoAndo Could you also briefly review this PR?
I especially would like you to verify that the directory structure looks OK to you.

How to store map-related files

If you only have one pointcloud map, Autoware will assume the following directory structure by default.

sample-map-rosbag
├── lanelet2_map.osm
├── pointcloud_map.pcd
└── pointcloud_map_metadata.yaml (not necessary when only a single PCD file exists)

If you have multiple files, an example directory structure would be as follows:

sample-map-rosbag
├── lanelet2_map.osm
├── pointcloud_map
│   ├── pcd_00.pcd
│   ├── pcd_01.pcd
│   └── pcd_02.pcd
└── pointcloud_map_metadata.yaml

Note that in this case, you have to launch autoware or simulators with a following command:

ros2 launch autoware_launch autoware.launch.xml map_path:=/PATH/TO/sample-map-rosbag pointcloud_map_file:=pointcloud_map ...

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 36.36% and project coverage change: +0.02 🎉

Comparison is base (11e4fcb) 13.08% compared to head (271c387) 13.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3205      +/-   ##
==========================================
+ Coverage   13.08%   13.10%   +0.02%     
==========================================
  Files        1257     1260       +3     
  Lines       88806    88877      +71     
  Branches    26865    26906      +41     
==========================================
+ Hits        11617    11647      +30     
- Misses      64944    64955      +11     
- Partials    12245    12275      +30     
Flag Coverage Δ *Carryforward flag
differential 34.07% <36.36%> (?)
total 13.08% <ø> (+<0.01%) ⬆️ Carriedforward from a71bc97

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...intcloud_map_loader/pointcloud_map_loader_node.cpp 1.75% <0.00%> (-0.42%) ⬇️
map/map_loader/src/pointcloud_map_loader/utils.hpp 0.00% <0.00%> (ø)
...ap_loader/test/test_replace_with_absolute_path.cpp 40.00% <40.00%> (ø)
map/map_loader/test/test_load_pcd_metadata.cpp 43.75% <43.75%> (ø)
map/map_loader/src/pointcloud_map_loader/utils.cpp 54.90% <54.54%> (-0.28%) ⬇️
...loud_map_loader/differential_map_loader_module.cpp 52.50% <75.00%> (+2.50%) ⬆️
...ointcloud_map_loader/partial_map_loader_module.cpp 61.29% <75.00%> (+2.03%) ⬆️
..._loader/test/test_pointcloud_map_loader_module.cpp 46.34% <100.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

kminoda added 3 commits March 30, 2023 13:35
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 029d038 into autowarefoundation:main Mar 31, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 3, 2023
…oad (autowarefoundation#3205)

* feat(map_loader): add grid coordinates for partial/differential map load

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove unnecessary line

* update arguments in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* slightly updated directory structure in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 6, 2023
…oad (autowarefoundation#3205)

* feat(map_loader): add grid coordinates for partial/differential map load

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove unnecessary line

* update arguments in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* slightly updated directory structure in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…oad (autowarefoundation#3205)

* feat(map_loader): add grid coordinates for partial/differential map load

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove unnecessary line

* update arguments in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* slightly updated directory structure in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kminoda kminoda deleted the feat/send_grid_coordinates_from_map_loader branch August 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants