-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_loader): add grid coordinates for partial/differential map load #3205
feat(map_loader): add grid coordinates for partial/differential map load #3205
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@RyuYamamoto Sorry again, this is the latest PR 🙏 |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
map/map_loader/src/pointcloud_map_loader/pointcloud_map_loader_node.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yukkysaito @YamatoAndo Could you also briefly review this PR? How to store map-related filesIf you only have one pointcloud map, Autoware will assume the following directory structure by default. sample-map-rosbag
├── lanelet2_map.osm
├── pointcloud_map.pcd
└── pointcloud_map_metadata.yaml (not necessary when only a single PCD file exists) If you have multiple files, an example directory structure would be as follows: sample-map-rosbag
├── lanelet2_map.osm
├── pointcloud_map
│ ├── pcd_00.pcd
│ ├── pcd_01.pcd
│ └── pcd_02.pcd
└── pointcloud_map_metadata.yaml Note that in this case, you have to launch autoware or simulators with a following command: ros2 launch autoware_launch autoware.launch.xml map_path:=/PATH/TO/sample-map-rosbag pointcloud_map_file:=pointcloud_map ... |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
==========================================
+ Coverage 13.08% 13.10% +0.02%
==========================================
Files 1257 1260 +3
Lines 88806 88877 +71
Branches 26865 26906 +41
==========================================
+ Hits 11617 11647 +30
- Misses 64944 64955 +11
- Partials 12245 12275 +30
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oad (autowarefoundation#3205) * feat(map_loader): add grid coordinates for partial/differential map load Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove unnecessary line * update arguments in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * slightly updated directory structure in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oad (autowarefoundation#3205) * feat(map_loader): add grid coordinates for partial/differential map load Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove unnecessary line * update arguments in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * slightly updated directory structure in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oad (autowarefoundation#3205) * feat(map_loader): add grid coordinates for partial/differential map load Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove unnecessary line * update arguments in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * slightly updated directory structure in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sample split map is here
sample-map-rosbag_split.zip
Here is a sample map split with metadata.yaml
Description
Please see https://github.com/orgs/autowarefoundation/discussions/3328 for the detail
You can use https://github.com/MapIV/pointcloud_divider for dividing pointcloud map into grids
Please find a how-to in updated readme
Should be merged after:
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.