Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tensorrt_yolox): resolve all output labels become unknown #3064

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Mar 13, 2023

Description

Currently, tensorrt_yolox assigns unknown for all detected objects.
After this PR, it seems correct labels are assigned.

Before

vokoscreenNG-2023-03-13_15-26-22.mp4

After

vokoscreenNG-2023-03-13_17-12-31.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 requested review from wep21, manato and a team as code owners March 13, 2023 08:27
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 13, 2023
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci.

Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the correction!

@ktro2828 ktro2828 enabled auto-merge (squash) March 13, 2023 10:24
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5ca8e68) 11.86% compared to head (1bb6537) 11.86%.

❗ Current head 1bb6537 differs from pull request most recent head 222387c. Consider uploading reports for the commit 222387c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
- Coverage   11.86%   11.86%   -0.01%     
==========================================
  Files        1333     1333              
  Lines       92800    92785      -15     
  Branches    24660    24653       -7     
==========================================
- Hits        11012    11008       -4     
+ Misses      70372    70364       -8     
+ Partials    11416    11413       -3     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 11.86% <ø> (-0.01%) ⬇️ Carriedforward from d8ab5f1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ception/tensorrt_yolox/src/tensorrt_yolox_node.cpp 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ktro2828 ktro2828 merged commit be0929b into autowarefoundation:main Mar 13, 2023
@ktro2828 ktro2828 deleted the fix/tensorrt-yolox-label branch April 10, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants