Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mpc): reset prev value when mpc failed #3062

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 13, 2023

Description

Before

The previous steering value in MPC is updated with the actual steering only when getData() failed.
-> when calculateMPC() is failed for any reason other than getData() , the previous steering value is not updated, which is unexpected.

After

The previous steering value in MPC is updated with the actual steering whenever calculateMPC() failed.

Related links

TIERIV'S INTERNAL LINK: https://tier4.atlassian.net/browse/T4PB-26780

Tests performed

Run psim in several paths.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from takayuki5168 and a team as code owners March 13, 2023 05:02
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Mar 13, 2023
@TakaHoribe TakaHoribe requested a review from tkimura4 March 13, 2023 05:03
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (0d4e444) 11.86% compared to head (68a1449) 11.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3062   +/-   ##
=======================================
  Coverage   11.86%   11.87%           
=======================================
  Files        1333     1333           
  Lines       92786    92787    +1     
  Branches    24649    24651    +2     
=======================================
+ Hits        11011    11015    +4     
+ Misses      70364    70358    -6     
- Partials    11411    11414    +3     
Flag Coverage Δ *Carryforward flag
differential 46.56% <50.00%> (?)
total 11.86% <ø> (+<0.01%) ⬆️ Carriedforward from 187d46c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._controller/include/mpc_lateral_controller/mpc.hpp 46.66% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 48.44% <ø> (+0.90%) ⬆️
..._lateral_controller/src/mpc_lateral_controller.cpp 34.76% <50.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe enabled auto-merge (squash) March 13, 2023 06:08
@TakaHoribe TakaHoribe merged commit 864d97d into autowarefoundation:main Mar 13, 2023
@TakaHoribe TakaHoribe deleted the fix/mpc-reset-prev-steering branch March 13, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants