fix(mpc): reset prev value when mpc failed #3062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before
The previous steering value in MPC is updated with the actual steering only when
getData()
failed.-> when
calculateMPC()
is failed for any reason other thangetData()
, the previous steering value is not updated, which is unexpected.After
The previous steering value in MPC is updated with the actual steering whenever
calculateMPC()
failed.Related links
TIERIV'S INTERNAL LINK: https://tier4.atlassian.net/browse/T4PB-26780
Tests performed
Run psim in several paths.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.