Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(system_error_monitor): supress initial warning #3056

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 11, 2023

Description

Suppress initial warning "input data is timeout" before initializing the ego pose.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (279e434) 11.93% compared to head (1ddc74e) 11.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3056   +/-   ##
=======================================
  Coverage   11.93%   11.93%           
=======================================
  Files        1321     1321           
  Lines       91938    91938           
  Branches    24525    24525           
=======================================
  Hits        10974    10974           
  Misses      69605    69605           
  Partials    11359    11359           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.93% <ø> (ø) Carriedforward from 279e434

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...em_error_monitor/src/system_error_monitor_core.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 marked this pull request as ready for review March 13, 2023 03:37
@takayuki5168 takayuki5168 requested review from ito-san, kenji-miyake and a team as code owners March 13, 2023 03:37
@takayuki5168
Copy link
Contributor Author

@ito-san Could you review the PR.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takayuki5168 Thank you for filing PR. I agree that screen gets busy by using one second.

@takayuki5168 takayuki5168 merged commit d8ab5f1 into autowarefoundation:main Mar 13, 2023
@takayuki5168 takayuki5168 deleted the chore/supress-system-warning branch March 13, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants