Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): remove the option march=native #3009

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 6, 2023

Description

Removed -march=native option in cmake since the building on CI sometimes fails maybe due to this option.
https://github.com/autowarefoundation/autoware.universe/actions/runs/4363535826/jobs/7629737397

I confirmed that the calculation time and accuracy did not change with this PR.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 6, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review March 9, 2023 15:59
@takayuki5168 takayuki5168 requested review from kosuke55 and a team as code owners March 9, 2023 15:59
@takayuki5168
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b72ca85) 12.75% compared to head (f85283e) 12.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3009   +/-   ##
=======================================
  Coverage   12.75%   12.76%           
=======================================
  Files        1218     1218           
  Lines       85978    85971    -7     
  Branches    24469    24470    +1     
=======================================
+ Hits        10965    10971    +6     
+ Misses      63652    63639   -13     
  Partials    11361    11361           
Flag Coverage Δ *Carryforward flag
differential 34.91% <ø> (?)
total 12.75% <ø> (+<0.01%) ⬆️ Carriedforward from b72ca85

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...ud_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <ø> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...cle_avoidance_planner/state_equation_generator.hpp 100.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 43.91% <0.00%> (+0.14%) ⬆️
...bstacle_avoidance_planner/src/eb_path_smoother.cpp 50.00% <0.00%> (+0.53%) ⬆️
...clude/obstacle_avoidance_planner/mpt_optimizer.hpp 85.71% <0.00%> (+1.09%) ⬆️
...avoidance_planner/src/state_equation_generator.cpp 66.66% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 2ace0d2 into autowarefoundation:main Mar 10, 2023
@takayuki5168 takayuki5168 deleted the fix/obstacle-avoidance-march-native branch March 10, 2023 01:24
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 4, 2023
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Apr 4, 2023
…warefoundation#3009) (#347)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants