-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tensorrt_yolox): add build only option for tensorrt engine #2982
feat(tensorrt_yolox): add build only option for tensorrt engine #2982
Conversation
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
7ac636d
to
48e72dc
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2982 +/- ##
==========================================
- Coverage 12.81% 12.76% -0.05%
==========================================
Files 1212 1216 +4
Lines 85613 85922 +309
Branches 24260 24260
==========================================
Hits 10968 10968
- Misses 63282 63591 +309
Partials 11363 11363
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@yukke42 Why don't you use |
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@wep21 |
@yukke42 |
@wep21 Yes, we can do the same thing with this option and trtexec. But it's hard to guarantee that the same engine file is generated as we expected. |
It may be out of scope from this PR, but I think the problem is that each package has own implementation to build tensorrt engine, while they do almost the same process. I think it is better to use
and then remove engine build function from each package. What do you think? |
@wep21 I see, Let me make a new discussion topic about it. |
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.