Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(joy_controller): delete default values #2943

Conversation

yamazakiTasuku
Copy link
Contributor

@yamazakiTasuku yamazakiTasuku commented Feb 24, 2023

Description

Removed default values defined in declare_parameter function.
joy_controller_delete_param.webm

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yamazakiTasuku yamazakiTasuku requested review from kenji-miyake and a team as code owners February 24, 2023 08:01
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Feb 24, 2023
@satoshi-ota satoshi-ota changed the title fix(joy_controller):delete default values fix(joy_controller): delete default values Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 11.52% // Head: 11.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f5e10c4) compared to base (e9e8553).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2943   +/-   ##
=======================================
  Coverage   11.52%   11.52%           
=======================================
  Files        1314     1314           
  Lines       92793    92792    -1     
  Branches    24996    24995    -1     
=======================================
  Hits        10697    10697           
+ Misses      70853    70852    -1     
  Partials    11243    11243           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.52% <ø> (+<0.01%) ⬆️ Carriedforward from e9e8553

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...troller/src/joy_controller/joy_controller_node.cpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.15% <ø> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota changed the title fix(joy_controller): delete default values refactor(joy_controller): delete default values Feb 26, 2023
Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
@satoshi-ota satoshi-ota merged commit 5f23514 into autowarefoundation:main Feb 27, 2023
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
)

delete param

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
)

delete param

Signed-off-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Co-authored-by: yamazakiTasuku <tasuku.yamazaki@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants