-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tier4_planning_rviz_plugin): clean up the code of path #2871
refactor(tier4_planning_rviz_plugin): clean up the code of path #2871
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
73a8b09
to
9c33856
Compare
@yukkysaito Could you review the PR. @kosuke55 Please let me know if there should be any difference among path_with_lane_id, path, and trajectory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 11.62% // Head: 11.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
==========================================
- Coverage 11.62% 11.61% -0.02%
==========================================
Files 1321 1324 +3
Lines 92212 92302 +90
Branches 24478 24478
==========================================
Hits 10724 10724
- Misses 70301 70391 +90
Partials 11187 11187
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
Plugin for PathWithLaneId/Path/Trajectory has almost the same structure.
I implemented the abstract class for them.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.