Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_planning_rviz_plugin): clean up the code of path #2871

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 11, 2023

Description

Plugin for PathWithLaneId/Path/Trajectory has almost the same structure.
I implemented the abstract class for them.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 11, 2023
@takayuki5168 takayuki5168 changed the title Refactor/tier4 planning rviz plugin path refactor(tier4_planning_rviz_plugin): clean up the code of path Feb 11, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/tier4-planning-rviz-plugin-path branch from 73a8b09 to 9c33856 Compare February 11, 2023 13:36
@takayuki5168 takayuki5168 marked this pull request as ready for review February 11, 2023 13:36
@takayuki5168 takayuki5168 requested review from yukkysaito and a team as code owners February 11, 2023 13:36
@takayuki5168
Copy link
Contributor Author

@yukkysaito Could you review the PR.

@kosuke55 Please let me know if there should be any difference among path_with_lane_id, path, and trajectory.
(I know some had velocity_text. With this PR, three all have velocity_text.)

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 11.62% // Head: 11.61% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9c33856) compared to base (93fbdb9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2871      +/-   ##
==========================================
- Coverage   11.62%   11.61%   -0.02%     
==========================================
  Files        1321     1324       +3     
  Lines       92212    92302      +90     
  Branches    24478    24478              
==========================================
  Hits        10724    10724              
- Misses      70301    70391      +90     
  Partials    11187    11187              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.65% <ø> (+0.02%) ⬆️ Carriedforward from 93fbdb9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_planning_rviz_plugin/include/path/display.hpp 0.00% <0.00%> (ø)
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <0.00%> (ø)
...ing_rviz_plugin/include/path_footprint/display.hpp 0.00% <0.00%> (ø)
...viz_plugin/include/path_footprint/display_base.hpp 0.00% <0.00%> (ø)
...on/tier4_planning_rviz_plugin/src/path/display.cpp 0.00% <0.00%> (ø)
...lanning_rviz_plugin/src/path_footprint/display.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit fb2bb6d into autowarefoundation:main Feb 11, 2023
@takayuki5168 takayuki5168 deleted the refactor/tier4-planning-rviz-plugin-path branch February 11, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants