Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ekf_localizer): typo #2795

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

VRichardJP
Copy link
Contributor

@VRichardJP VRichardJP commented Feb 2, 2023

Signed-off-by: Vincent Richard vincent.francois.richard@gmail.com

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Feb 2, 2023
@kenji-miyake
Copy link
Contributor

@VRichardJP Thanks! Regarding the title, I think style(ekf_localizer): fix typo is better because it's not a bug fix. Or, I guess chore can also be used.

@VRichardJP VRichardJP changed the title fix(ekf_localizer): typo chore(ekf_localizer): typo Feb 2, 2023
Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@TakaHoribe TakaHoribe enabled auto-merge (squash) February 6, 2023 13:29
@TakaHoribe TakaHoribe merged commit ba3ae68 into autowarefoundation:main Feb 6, 2023
@VRichardJP VRichardJP deleted the patch-3 branch February 6, 2023 14:06
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Mar 23, 2023
Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Apr 4, 2023
Signed-off-by: Vincent Richard <vincent.francois.richard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants