-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accel_brake_map_calibrator): fix usage of transform listener #2682
fix(accel_brake_map_calibrator): fix usage of transform listener #2682
Conversation
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov ReportBase: 11.38% // Head: 12.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
==========================================
+ Coverage 11.38% 12.12% +0.73%
==========================================
Files 1277 1177 -100
Lines 89252 83810 -5442
Branches 23627 23627
==========================================
- Hits 10160 10158 -2
+ Misses 68321 62880 -5441
- Partials 10771 10772 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…owarefoundation#2682) * fix(accel_brake_map_calibrator): fix usage of transform listener Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add maintainer Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…owarefoundation#2682) (#249) * fix(accel_brake_map_calibrator): fix usage of transform listener Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add maintainer Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…owarefoundation#2682) * fix(accel_brake_map_calibrator): fix usage of transform listener Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add maintainer Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…owarefoundation#2682) * fix(accel_brake_map_calibrator): fix usage of transform listener Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add maintainer Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp
Description
Fix usage of transform listener.
transform_listener_->getTransform
don't throw an error when getting transform fails. So, in current implementation, accel_brake_map_calibrator dies when there is no available tf. I fixed it.Related links
Tests performed
I confirmed that the accel_brake_map_calibrator node does not die using rosbag.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.