Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accel_brake_map_calibrator): fix usage of transform listener #2682

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jan 18, 2023

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

Fix usage of transform listener.

transform_listener_->getTransform don't throw an error when getting transform fails. So, in current implementation, accel_brake_map_calibrator dies when there is no available tf. I fixed it.
image

Related links

Tests performed

I confirmed that the accel_brake_map_calibrator node does not die using rosbag.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from a team as a code owner January 18, 2023 09:29
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Jan 18, 2023
@tkimura4 tkimura4 enabled auto-merge (squash) January 18, 2023 09:36
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tkimura4 tkimura4 disabled auto-merge January 18, 2023 09:38
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 11.38% // Head: 12.12% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (8d24caf) compared to base (8cb82b3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   11.38%   12.12%   +0.73%     
==========================================
  Files        1277     1177     -100     
  Lines       89252    83810    -5442     
  Branches    23627    23627              
==========================================
- Hits        10160    10158       -2     
+ Misses      68321    62880    -5441     
- Partials    10771    10772       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 12.16% <0.00%> (+0.78%) ⬆️ Carriedforward from 8cb82b3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
...loud_map_loader/differential_map_loader_module.cpp 0.00% <0.00%> (ø)
...ointcloud_map_loader/partial_map_loader_module.cpp 0.00% <ø> (ø)
...tcloud_map_loader/pointcloud_map_loader_module.cpp 0.00% <0.00%> (ø)
...calibrator/src/accel_brake_map_calibrator_node.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 80.95% <0.00%> (-4.77%) ⬇️
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit 5f9d847 into autowarefoundation:main Jan 18, 2023
@tkimura4 tkimura4 deleted the fix/accel_brake_map_tf branch January 18, 2023 10:55
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2023
…owarefoundation#2682)

* fix(accel_brake_map_calibrator): fix usage of transform listener

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add maintainer

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2023
…owarefoundation#2682) (#249)

* fix(accel_brake_map_calibrator): fix usage of transform listener

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add maintainer

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
…owarefoundation#2682)

* fix(accel_brake_map_calibrator): fix usage of transform listener

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add maintainer

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
…owarefoundation#2682)

* fix(accel_brake_map_calibrator): fix usage of transform listener

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add maintainer

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants