refactor(ekf_localizer): remove info structs #2656
Merged
+47
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshitaTakeshi
requested review from
kminoda,
TakaHoribe,
YamatoAndo and
a team
as code owners
github-actions
bot
added
the
component:localization
kminoda
reviewed
Jan 16, 2023
localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp
Outdated
Show resolved
Hide resolved
kminoda
reviewed
Jan 18, 2023
localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 11.39% // Head: 11.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
- Coverage 11.39% 11.37% -0.02%
==========================================
Files 1279 1279
Lines 89165 89304 +139
Branches 23586 23704 +118
==========================================
Hits 10160 10160
- Misses 68232 68358 +126
- Partials 10773 10786 +13
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Jan 30, 2023
* Remove smoothing_steps from the pose/twist structs * Remove the PoseInfo and TwistInfo structs Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen
pushed a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Mar 23, 2023
* Remove smoothing_steps from the pose/twist structs * Remove the PoseInfo and TwistInfo structs Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen
pushed a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Apr 4, 2023
* Remove smoothing_steps from the pose/twist structs * Remove the PoseInfo and TwistInfo structs Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Structs inhibit flat software design. I removed the pose / twist structs to flatten the software structure.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.