Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): visualize full pull out path as candidate #2643

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 12, 2023

Description

visualize pull out full path as a candidate path even if separated arc path.

Related links

tier4_interanal_link

Tests performed

psim

pull_out_full_path-2023-01-12_20.46.57.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 12, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/visualize_arc_pull_out_full_path branch from 69dc8bd to d9897b0 Compare January 12, 2023 11:57
@kosuke55 kosuke55 changed the title Feat/visualize arc pull out full path feat(behavior_path_planner): visualize full pull out path as candidate Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 12.18% // Head: 12.14% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (d9897b0) compared to base (e77bc20).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
- Coverage   12.18%   12.14%   -0.04%     
==========================================
  Files        1179     1179              
  Lines       83396    83653     +257     
  Branches    23586    23794     +208     
==========================================
+ Hits        10158    10159       +1     
- Misses      62466    62669     +203     
- Partials    10772    10825      +53     
Flag Coverage Δ *Carryforward flag
differential 4.97% <0.00%> (?)
total 12.18% <0.00%> (ø) Carriedforward from e77bc20

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...ene_module/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...ne_module/lane_following/lane_following_module.hpp 0.00% <ø> (ø)
...nner/scene_module/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...er/scene_module/pull_over/pull_over_parameters.hpp 0.00% <ø> (ø)
...nner/scene_module/side_shift/side_shift_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.24% <0.00%> (+0.08%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit b083510 into autowarefoundation:main Jan 12, 2023
@kosuke55 kosuke55 deleted the feat/visualize_arc_pull_out_full_path branch January 12, 2023 13:40
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 12, 2023
autowarefoundation#2643)

feat(behavior_path_planner): visualize full pull out path as candidate

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 12, 2023
#241)

feat(behavior_path_planner): visualize full pull out path as candidate  (autowarefoundation#2643)

feat(behavior_path_planner): visualize full pull out path as candidate

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants