Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package #2336

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Nov 21, 2022

Description

Add radar_scan_to_pointcloud2 package.
This package follow proposed radar sensing architecture.

Related links

Tests performed

Test by rosbag.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 10.47% // Head: 10.46% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (eb36841) compared to base (1940b87).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
- Coverage   10.47%   10.46%   -0.01%     
==========================================
  Files        1248     1253       +5     
  Lines       91327    91140     -187     
  Branches    21037    20919     -118     
==========================================
- Hits         9566     9538      -28     
- Misses      71573    71611      +38     
+ Partials    10188     9991     -197     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.44% <0.00%> (-0.01%) ⬇️ Carriedforward from a9a55ec

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
...rture_checker_node/lane_departure_checker_node.cpp 0.41% <0.00%> (ø)
...ion/crosswalk_traffic_light_estimator/src/node.cpp 0.00% <0.00%> (ø)
.../include/traffic_light_map_based_detector/node.hpp 0.00% <ø> (ø)
...tion/traffic_light_map_based_detector/src/node.cpp 0.00% <0.00%> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.19% <0.00%> (+<0.01%) ⬆️
...clude/freespace_planner/freespace_planner_node.hpp 0.00% <ø> (ø)
...r/src/freespace_planner/freespace_planner_node.cpp 0.00% <0.00%> (ø)
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp 0.00% <0.00%> (ø)
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drwnz
Copy link
Contributor

drwnz commented Nov 21, 2022

In the linked radar sensing architecture design document, there was discussion about populating custom fields but no clear consensus. Although I understand the problem of portability when different devices have different data fields, I feel like association between two different clouds may be a large issue - for example if you want to use both doppler and amplitude information for a perception task. In which case, custom fields in a single pointcloud would appear to be cleaner and more compact than publishing multiple clouds. But since I have not directly used these fields, interested in further discussion on this. Thanks!

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the feature/radar_scan_to_pointcloud2 branch from 073377d to 45d0f2d Compare November 22, 2022 09:36
@yukkysaito yukkysaito self-requested a review November 24, 2022 05:57
scepter914 and others added 4 commits November 24, 2022 15:13
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the feature/radar_scan_to_pointcloud2 branch 3 times, most recently from a1d1d70 to 25c962b Compare November 24, 2022 08:07
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the feature/radar_scan_to_pointcloud2 branch from 25c962b to b53d591 Compare November 24, 2022 08:47
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the feature/radar_scan_to_pointcloud2 branch from ad336c2 to 62b51cb Compare November 25, 2022 03:21
@scepter914
Copy link
Contributor Author

scepter914 commented Nov 25, 2022

Now I finish fixing some points for galactic CI fail.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 4623388 into autowarefoundation:main Dec 1, 2022
@scepter914 scepter914 deleted the feature/radar_scan_to_pointcloud2 branch December 1, 2022 15:07
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
autowarefoundation#2336)

* feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre-commit

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameters

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre-commit

Signed-off-by: scepter914 <scepter914@gmail.com>

* make temporary variable

Signed-off-by: scepter914 <scepter914@gmail.com>

* use autoware_cmame in CMakeLists.txt

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* add dependancy

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix build error at galactic enviroment

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply cpplint

Signed-off-by: scepter914 <scepter914@gmail.com>

* add code maintainer

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply cpplint

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
autowarefoundation#2336)

* feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre-commit

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix parameters

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre-commit

Signed-off-by: scepter914 <scepter914@gmail.com>

* make temporary variable

Signed-off-by: scepter914 <scepter914@gmail.com>

* use autoware_cmame in CMakeLists.txt

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* add dependancy

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix build error at galactic enviroment

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply cpplint

Signed-off-by: scepter914 <scepter914@gmail.com>

* add code maintainer

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply cpplint

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants