-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package #2336
feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package #2336
Conversation
Codecov ReportBase: 10.47% // Head: 10.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
- Coverage 10.47% 10.46% -0.01%
==========================================
Files 1248 1253 +5
Lines 91327 91140 -187
Branches 21037 20919 -118
==========================================
- Hits 9566 9538 -28
- Misses 71573 71611 +38
+ Partials 10188 9991 -197
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In the linked radar sensing architecture design document, there was discussion about populating custom fields but no clear consensus. Although I understand the problem of portability when different devices have different data fields, I feel like association between two different clouds may be a large issue - for example if you want to use both doppler and amplitude information for a perception task. In which case, custom fields in a single pointcloud would appear to be cleaner and more compact than publishing multiple clouds. But since I have not directly used these fields, interested in further discussion on this. Thanks! |
...ar_scan_to_pointcloud2/src/radar_scan_to_pointcloud2_node/radar_scan_to_pointcloud2_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
073377d
to
45d0f2d
Compare
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
a1d1d70
to
25c962b
Compare
Signed-off-by: scepter914 <scepter914@gmail.com>
25c962b
to
b53d591
Compare
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
ad336c2
to
62b51cb
Compare
Now I finish fixing some points for galactic CI fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
autowarefoundation#2336) * feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * fix parameters Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * make temporary variable Signed-off-by: scepter914 <scepter914@gmail.com> * use autoware_cmame in CMakeLists.txt Signed-off-by: scepter914 <scepter914@gmail.com> * refactor Signed-off-by: scepter914 <scepter914@gmail.com> * add dependancy Signed-off-by: scepter914 <scepter914@gmail.com> * fix build error at galactic enviroment Signed-off-by: scepter914 <scepter914@gmail.com> * apply cpplint Signed-off-by: scepter914 <scepter914@gmail.com> * add code maintainer Signed-off-by: scepter914 <scepter914@gmail.com> * apply cpplint Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
autowarefoundation#2336) * feat(radar_scan_to_pointcloud2): add radar_scan_to_pointcloud2 package Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * fix parameters Signed-off-by: scepter914 <scepter914@gmail.com> * apply pre-commit Signed-off-by: scepter914 <scepter914@gmail.com> * make temporary variable Signed-off-by: scepter914 <scepter914@gmail.com> * use autoware_cmame in CMakeLists.txt Signed-off-by: scepter914 <scepter914@gmail.com> * refactor Signed-off-by: scepter914 <scepter914@gmail.com> * add dependancy Signed-off-by: scepter914 <scepter914@gmail.com> * fix build error at galactic enviroment Signed-off-by: scepter914 <scepter914@gmail.com> * apply cpplint Signed-off-by: scepter914 <scepter914@gmail.com> * add code maintainer Signed-off-by: scepter914 <scepter914@gmail.com> * apply cpplint Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Description
Add
radar_scan_to_pointcloud2
package.This package follow proposed radar sensing architecture.
Related links
Tests performed
Test by rosbag.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.