Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_simulator): add initial twist for debug purpose #2268

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Nov 11, 2022

Description

Add an initial twist input in the simple_planning_simulator for debug purposes.

how to use: publish the following command after ego pose and goal is set in the planning simulator. You can see the ego velocity at 40km/h.

ros2 topic pub /simulation/input/initialtwist geometry_msgs/msg/TwistStamped "{twist: {linear: {x: 11.11}}}" -r 100

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 10.59% // Head: 10.68% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (ef1f8cd) compared to base (a6392e7).
Patch coverage: 1.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
+ Coverage   10.59%   10.68%   +0.08%     
==========================================
  Files        1265     1265              
  Lines       87403    87536     +133     
  Branches    20876    20968      +92     
==========================================
+ Hits         9262     9349      +87     
- Misses      68274    68291      +17     
- Partials     9867     9896      +29     
Flag Coverage Δ *Carryforward flag
differential 55.13% <14.28%> (?)
total 10.59% <0.00%> (ø) Carriedforward from 3403181

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)
...nning_simulator/simple_planning_simulator_core.hpp 71.42% <ø> (-6.35%) ⬇️
...nning_simulator/simple_planning_simulator_core.cpp 45.83% <10.00%> (+7.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe requested a review from tkimura4 November 12, 2022 08:42
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cap-.2022-12-05-13-40-28.mp4.mp4

@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Dec 5, 2022
@TakaHoribe TakaHoribe enabled auto-merge (squash) December 5, 2022 04:44
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the add-initial-twist-simple-sim branch from 7f8ad15 to 3403181 Compare December 5, 2022 04:45
@TakaHoribe TakaHoribe requested a review from a team as a code owner December 5, 2022 04:45
@TakaHoribe TakaHoribe requested a review from tkimura4 December 5, 2022 05:17
@TakaHoribe TakaHoribe merged commit ae49c3f into autowarefoundation:main Dec 5, 2022
@TakaHoribe TakaHoribe deleted the add-initial-twist-simple-sim branch December 5, 2022 05:36
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Dec 9, 2022
…utowarefoundation#2268)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…utowarefoundation#2268)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…utowarefoundation#2268)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants