Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply renaming of vector map route message #2257

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Nov 9, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Apply autowarefoundation/autoware_msgs#41

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@xmfcx
Copy link
Contributor

xmfcx commented Nov 9, 2022

I've merged autowarefoundation/autoware_msgs#41

Now re-running the CI jobs here.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 11.23% // Head: 11.24% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (bc980b7) compared to base (1321f64).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   11.23%   11.24%   +0.01%     
==========================================
  Files        1197     1197              
  Lines       79302    79331      +29     
  Branches    20346    20408      +62     
==========================================
+ Hits         8909     8921      +12     
+ Misses      60640    60627      -13     
- Partials     9753     9783      +30     
Flag Coverage Δ *Carryforward flag
differential 4.46% <0.00%> (?)
total 11.22% <0.00%> (-0.01%) ⬇️ Carriedforward from 1321f64

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
...stem/default_ad_api/src/utils/route_conversion.cpp 0.00% <ø> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 64.15% <0.00%> (-9.44%) ⬇️
...planning_evaluator/src/planning_evaluator_node.cpp 32.96% <0.00%> (-2.20%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...on_planner/src/mission_planner/arrival_checker.cpp 0.00% <0.00%> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 0.00% <0.00%> (ø)
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked and couldn't find any other usage of the now-refactored terms, also builds fine. Thanks!

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx @isamu-takagi thank you!

@isamu-takagi isamu-takagi merged commit 28c047d into autowarefoundation:main Nov 9, 2022
@isamu-takagi isamu-takagi deleted the feature/rename-vector-map-route branch November 9, 2022 12:49
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…2257)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…2257)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants