Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): isPathGoalChanged #2205

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 3, 2022

Description

Fix isPathGoalChanged. Currently always return false, if having prev_path_points_ptr_.

Related links

TIERIV INTERNAL LINK

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 11.09% // Head: 11.09% // No change to project coverage 👍

Coverage data is based on head (a389a90) compared to base (d10310d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   11.09%   11.09%           
=======================================
  Files        1202     1202           
  Lines       86169    86169           
  Branches    20682    20682           
=======================================
  Hits         9564     9564           
  Misses      66523    66523           
  Partials    10082    10082           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.07% <0.00%> (ø) Carriedforward from d10310d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 333044b into autowarefoundation:main Nov 3, 2022
@kosuke55 kosuke55 deleted the fix/obstalcle_avoidance_goal_change branch November 3, 2022 07:11
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…n#2205)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…n#2205)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants