Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #2140

Merged
merged 2 commits into from
Oct 25, 2022
Merged

chore: fix typos #2140

merged 2 commits into from
Oct 25, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Oct 24, 2022

Description

There were some spell-check errors.

perception/multi_object_tracker/config/data_association_matrix.param.yaml:25:14 Unknown word (yukke)
perception/multi_object_tracker/config/data_association_matrix.param.yaml:26:14 Unknown word (yukke)
common/perception_utils/test/src/test_matching.cpp:100:29 Unknown word (icludes)
common/perception_utils/test/src/test_matching.cpp:101:6 Unknown word (Threfore)
perception/ground_segmentation/docs/scan-ground-filter.md:61:43 Unknown word (Shen)
perception/ground_segmentation/docs/scan-ground-filter.md:61:51 Unknown word (Liang)
planning/behavior_velocity_planner/intersection-design.md:32:22 Unknown word (neighbouring)
planning/behavior_velocity_planner/intersection-design.md:33:5 Unknown word (neighbouring)

Actually, neighbouring isn't completely wrong, but we should use American spelling.
https://developers.google.com/style/spelling

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Kenji Miyake added 2 commits October 24, 2022 19:42
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 10.75% // Head: 10.75% // No change to project coverage 👍

Coverage data is based on head (66a7c4d) compared to base (3a4845c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2140   +/-   ##
=======================================
  Coverage   10.75%   10.75%           
=======================================
  Files        1186     1186           
  Lines       84749    84749           
  Branches    19825    19825           
=======================================
  Hits         9114     9114           
  Misses      66125    66125           
  Partials     9510     9510           
Flag Coverage Δ *Carryforward flag
differential 4.59% <ø> (?)
total 10.73% <ø> (ø) Carriedforward from 3a4845c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/perception_utils/test/src/test_matching.cpp 78.18% <ø> (ø)
...rpoint/lib/postprocess/non_maximum_suppression.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants