Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emergency_handler): stop using heartbeat_checher to make subscriber unique #2138

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Oct 24, 2022

Description

Now, subscriber for hazard_status is duplicate due to processing data and checking heartbeat.
I think a subscriber should be as unique as possible for a topic.
I'll fix it.
Moreover, I'll delete heartbeat checker implementation because it is only used in emergency_handler

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 10.76% // Head: 10.75% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a2de17b) compared to base (253b5b9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
- Coverage   10.76%   10.75%   -0.01%     
==========================================
  Files        1186     1186              
  Lines       84749    84822      +73     
  Branches    19827    19827              
==========================================
  Hits         9119     9119              
- Misses      65991    66064      +73     
  Partials     9639     9639              
Flag Coverage Δ *Carryforward flag
differential 12.36% <0.00%> (?)
total 10.73% <0.00%> (ø) Carriedforward from 253b5b9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/emergency_handler/emergency_handler_core.hpp 0.00% <ø> (ø)
...r/src/emergency_handler/emergency_handler_core.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta h-ohta marked this pull request as ready for review October 24, 2022 23:58
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a trade-off between simplicity and computation costs (this time, creating multiple callbacks).
If you will maintain this package, this change is okay for me.

@h-ohta h-ohta force-pushed the fix/stop_using_heartbeat_checker branch from d639bb5 to a2de17b Compare October 25, 2022 00:45
@h-ohta h-ohta enabled auto-merge (squash) October 25, 2022 00:50
@h-ohta
Copy link
Contributor Author

h-ohta commented Oct 25, 2022

I'ts true, but deleting and integrating heart beat library is more simple because the library is only used at only one node now.

@h-ohta
Copy link
Contributor Author

h-ohta commented Oct 25, 2022

FYI #1501 (comment)

@h-ohta h-ohta merged commit 641b84b into autowarefoundation:main Oct 25, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…er unique (autowarefoundation#2138)

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@h-ohta h-ohta deleted the fix/stop_using_heartbeat_checker branch January 11, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants