Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(system_error_monitor): fix typo in fix_system_param.yaml #2123

Merged

Conversation

ito-san
Copy link
Contributor

@ito-san ito-san commented Oct 20, 2022

Signed-off-by: ito-san fumihito.ito@tier4.jp

Description

Fixed minor typo in system_param.yaml.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ito-san <fumihito.ito@tier4.jp>
@ito-san ito-san requested a review from kenji-miyake as a code owner October 20, 2022 08:08
@ito-san ito-san self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 11.60% // Head: 11.60% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (12059f9) compared to base (1953ad7).
Patch coverage: 11.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
- Coverage   11.60%   11.60%   -0.01%     
==========================================
  Files        1087     1087              
  Lines       72589    72608      +19     
  Branches    19384    19384              
==========================================
  Hits         8426     8426              
- Misses      54919    54938      +19     
  Partials     9244     9244              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.60% <11.76%> (ø) Carriedforward from 1953ad7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/operation_mode_transition_manager/data.hpp 0.00% <ø> (ø)
...tion_manager/operation_mode_transition_manager.hpp 0.00% <ø> (ø)
...nclude/operation_mode_transition_manager/state.hpp 0.00% <ø> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <0.00%> (ø)
...clude/planning_debug_tools/trajectory_analyzer.hpp 0.00% <ø> (ø)
...g/planning_debug_tools/src/trajectory_analyzer.cpp 0.00% <0.00%> (ø)
...nning_simulator/simple_planning_simulator_core.hpp 77.77% <ø> (ø)
...nning_simulator/simple_planning_simulator_core.cpp 39.49% <22.22%> (ø)
...em_error_monitor/src/system_error_monitor_core.cpp 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ito-san ito-san merged commit 4fb77da into autowarefoundation:main Oct 20, 2022
@ito-san ito-san deleted the chore/fix_typo_system_param_yaml branch October 20, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants