Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add goal safe distance #2031

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Oct 6, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Add a new parameter for safe stop distance when stopping at a goal
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901
Copy link
Contributor Author

@kosuke55

@purewater0901
Copy link
Contributor Author

Launch PR

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 10.40% // Head: 10.45% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (1f9dc40) compared to base (84a66fe).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
+ Coverage   10.40%   10.45%   +0.05%     
==========================================
  Files        1169     1164       -5     
  Lines       83489    76923    -6566     
  Branches    19549    19134     -415     
==========================================
- Hits         8686     8046     -640     
+ Misses      65301    59758    -5543     
+ Partials     9502     9119     -383     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.49% <0.00%> (+0.11%) ⬆️ Carriedforward from 84a66fe

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/obstacle_cruise_planner/common_structs.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
system/default_ad_api/src/localization.cpp 0.00% <0.00%> (-42.86%) ⬇️
system/default_ad_api/src/routing.cpp 0.00% <0.00%> (-37.50%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...wer/include/trajectory_follower/lowpass_filter.hpp 50.00% <0.00%> (-25.00%) ⬇️
... and 744 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 reopened this Oct 6, 2022
@purewater0901 purewater0901 merged commit d707d2b into autowarefoundation:main Oct 6, 2022
@purewater0901 purewater0901 deleted the feat/fix-terminal-stop-distance branch October 6, 2022 17:41
@kosuke55
Copy link
Contributor

memo:
terminal collision check was implemented in #1807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants