Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP refactor(ndt_scan_matcher): isolate align function into ndt package #1987

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 29, 2022

Signed-off-by: kminoda koji.m.minoda@gmail.com

Description

I propose to isloate align function in ndt package.

Current interface of ndt_ptr_ (defined in ndt) is a bit redundant. It would be easier to handle the object by making a new function as

const NdtResult ndt_result = ndt_ptr_->align(initial_guess_pose)

I will make this pull request open after #2024.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda kminoda requested a review from YamatoAndo September 29, 2022 09:18
@kminoda kminoda changed the title first commit refactor(ndt_scan_matcher): isolate align function into ndt package Sep 29, 2022
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda kminoda force-pushed the refactor/ndt_scan_matcher/isolate_align_function_into_ndt branch 2 times, most recently from aa6b5bb to 28fb27b Compare September 29, 2022 09:53
pre-commit-ci bot and others added 2 commits September 29, 2022 09:55
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda kminoda marked this pull request as ready for review October 5, 2022 08:16
@kminoda kminoda marked this pull request as draft October 6, 2022 01:47
@kminoda kminoda changed the title refactor(ndt_scan_matcher): isolate align function into ndt package WIP refactor(ndt_scan_matcher): isolate align function into ndt package Oct 6, 2022
@kminoda
Copy link
Contributor Author

kminoda commented Oct 6, 2022

@TakaHoribe
I want to include tf2_eigen in tier4_autoware_utils/geometry.hpp in this PR, but it seems that the toMsg namespace conflicts in behavior_velocity_planner (with this one: here).

Here's some solutions I have in mind:

  • change the name of the toMsg function in the behavior_velocity_planner
  • add a namespace before the function in behavior_velocity_planner (like behavior_velocity_planner::toMsg())
  • make the new functions in tier4_autoware_utils as a separate file

Do you have any preferences on these three? (or do you have any other better idea?)

@kminoda kminoda closed this Oct 13, 2022
@kminoda kminoda deleted the refactor/ndt_scan_matcher/isolate_align_function_into_ndt branch August 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant