-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(image_projection_based_fusion): fix input to quaternion #1933
fix(image_projection_based_fusion): fix input to quaternion #1933
Conversation
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Codecov ReportBase: 10.28% // Head: 10.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
+ Coverage 10.28% 10.37% +0.08%
==========================================
Files 1147 1141 -6
Lines 81946 75239 -6707
Branches 19035 18656 -379
==========================================
- Hits 8429 7806 -623
+ Misses 64396 58665 -5731
+ Partials 9121 8768 -353
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
…foundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
…foundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
…foundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
…foundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
…foundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
* feat: multiframe-pointpainting Signed-off-by: tzhong518 <sworgun@gmail.com> * ci(pre-commit): autofix * fix: retrieve changes of classremap Signed-off-by: tzhong518 <sworgun@gmail.com> * fix(image_projection_based_fusion): fix input to quaternion (#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * add: launch files Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
…refoundation#2124) * feat: multiframe-pointpainting Signed-off-by: tzhong518 <sworgun@gmail.com> * ci(pre-commit): autofix * fix: retrieve changes of classremap Signed-off-by: tzhong518 <sworgun@gmail.com> * fix(image_projection_based_fusion): fix input to quaternion (autowarefoundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * add: launch files Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
…refoundation#2124) * feat: multiframe-pointpainting Signed-off-by: tzhong518 <sworgun@gmail.com> * ci(pre-commit): autofix * fix: retrieve changes of classremap Signed-off-by: tzhong518 <sworgun@gmail.com> * fix(image_projection_based_fusion): fix input to quaternion (autowarefoundation#1933) Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * add: launch files Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp
Description
The input to
Eigen::Quaterniond
is (w, x, y, z).https://eigen.tuxfamily.org/dox/classEigen_1_1Quaternion.html#a3eba7a582f77a8f30525614821d7056f
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.